Give the modifications an applicability for the tag of a new root network by flomillot · Pull Request #940 · gridsuite/network-modification-server

flomillot · 2026-10-16T14:01:45Z

Replaces #918.

Adds POST /network-modifications/root-network-tag?groupUuids&newTag: the modifications of the groups, and the shared ones they point to, get an applicability for the new tag unless they already have one. It is false when one of their applicabilities, for any tag, is false, and true otherwise.

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

…t-network-applicabilities Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

…work Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

coderabbitai · 2026-10-16T14:01:57Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 3f9d1f15-af26-4924-8b21-fca602ed0ab7

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

ghazwarhili · 2026-10-20T15:02:21Z

+        SELECT m, :tag, CASE WHEN EXISTS (SELECT 1 FROM ModificationRootNetworkApplicabilityEntity a
+                                           WHERE a.modification = m AND a.applicable = false) THEN false ELSE true END
+          FROM ModificationEntity m
+         WHERE m.id IN (:ids) AND TYPE(m) <> ModificationReferenceEntity


All modification UUIDs go into a single IN (:ids) ?
we don't have sql limit here otherwise it will be rejected by sql? maybe we could filter by groupuuid ?
@etiennehomer what do you think ?

With postgres, the limit is 65 535 parameters in IN clause. Should be ok

ghazwarhili · 2026-10-20T15:03:37Z

+           AND NOT EXISTS (SELECT 1 FROM ModificationRootNetworkApplicabilityEntity a
+                            WHERE a.modification = m AND a.rootNetworkTag = :tag)
+        """)
+    void addRootNetworkApplicabilityIfMissing(@Param("ids") Collection<UUID> ids, @Param("tag") String tag);


it is too complicated query, it should be reviewed by @etiennehomer or @SlimaneAmar

To me, we should avoid as much as we can to put intelligence in the SQL. Most of the complexity should be done in java with understandable code.
If an optimization is needed, it should only be an INSERT with a list of modification uuids and a list of applicabilities
Same as https://github.com/gridsuite/network-modification-server/pull/932/changes#r4324384990

Yes I will remove it

ghazwarhili · 2026-10-20T15:06:36Z

+    @Query("""
+        INSERT INTO ModificationRootNetworkApplicabilityEntity (modification, rootNetworkTag, applicable)
+        SELECT m, :tag, CASE WHEN EXISTS (SELECT 1 FROM ModificationRootNetworkApplicabilityEntity a
+                                           WHERE a.modification = m AND a.applicable = false) THEN false ELSE true END


including tags that are not in the study anymore ?

Yes, whatever the study

ghazwarhili · 2026-10-20T15:08:50Z

+        if (ownedUuids.isEmpty()) {
+            return;
+        }
+        Set<UUID> sharedModificationTreesUuids = getSharedModificationTrees(ownedUuids).allUuids();


these first lines are the same as in renameRootNetworkTag
=> create small private function to avoid fixing this in two places lates

Can you suggest something because I don't see how to make it without adding more code ?

you can create record hold both result of what you called ownedUuids and sharedTreesUuids ...
never mind it can be done next time

Yes but it add more codes, create a record used only once, and don't make it clearer IMO, unless I haven't understand