Repository navigation
Conversation
A stashed modification reference, or one nested in a stashed composite, is
unlinked from its shared modification and deleted: the trash no longer holds
any reference, so restoring no longer links them back.
Add DELETE /groups/{groupUuid}/references, called when a node is stashed, and
stop unlinking references when deleting the stashed modifications of groups.
A migration deletes the references already stashed.
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
flomillot
requested review from
EtienneLt,
SlimaneAmar and
etiennehomer
as code owners
October 19, 2026 15:42
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…-list' into feat/delete-modification-references-instead-of-stashing Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Put it next to the deletion of the references of a group. Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Both now return the uuids of the deleted references. Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…-list' into feat/delete-modification-references-instead-of-stashing Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com> # Conflicts: # src/main/java/org/gridsuite/modification/server/NetworkModificationController.java
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…-list' into feat/delete-modification-references-instead-of-stashing Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…-list' into feat/delete-modification-references-instead-of-stashing Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com> # Conflicts: # src/test/java/org/gridsuite/modification/server/service/NetworkModificationServiceTest.java
…-list' into feat/delete-modification-references-instead-of-stashing Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…-list' into feat/delete-modification-references-instead-of-stashing Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…-list' into feat/delete-modification-references-instead-of-stashing Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stashing a modification reference now deletes it, and unlinks it from its shared modification in directory-server through the deletion of #943. This also applies to the references nested in a stashed composite, which goes to the trash without them, and to a reference stashed from inside a shared composite. The trash therefore never holds a reference, and restoring modifications no longer links references back: the
nodeContainerUuidandstudyRootContainerUuidparameters are removed.Node trash:
DELETE /groups/{groupUuid}/referencesdeletes the references of a group, those nested in its composites included, andDELETE /groups/stashed-modificationsno longer unlinks the references of the groups.A migration deletes the references already stashed and those nested in stashed composites.
Based on #943. To deploy with gridsuite/study-server#1141.