Skip to content

Delete modification references instead of stashing them - #1141

Open
flomillot wants to merge 12 commits into
refactor/delete-modifications-by-listfrom
feat/delete-modification-references-instead-of-stashing
Open

flomillot wants to merge 12 commits into
refactor/delete-modifications-by-listfrom
feat/delete-modification-references-instead-of-stashing

Conversation

@flomillot

@flomillot flomillot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Stashing a node deletes its modification references, through network-modification-server, instead of only unlinking them. Restoring a node or modifications no longer links references back, and deleting stashed modifications no longer unlinks references, since the trash holds none.

Based on #1140. To deploy after gridsuite/network-modification-server#944.

Stashing a node deletes its modification references, restoring a node or a
modification no longer links them back, and deleting stashed modifications no
longer unlinks references.

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f0b4c42f-aa76-43f1-afb6-2ea8e519b6f4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

flomillot and others added 11 commits October 20, 2026 15:33
…-list' into feat/delete-modification-references-instead-of-stashing

Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>

# Conflicts:
#	src/main/java/org/gridsuite/study/server/service/StudyService.java
#	src/test/java/org/gridsuite/study/server/NetworkModificationTest.java
…-modification-references-instead-of-stashing

Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>

# Conflicts:
#	src/main/java/org/gridsuite/study/server/service/StudyService.java
#	src/test/java/org/gridsuite/study/server/NetworkModificationTest.java
…-list' into feat/delete-modification-references-instead-of-stashing

Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>

# Conflicts:
#	src/main/java/org/gridsuite/study/server/service/StudyService.java
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…-list' into HEAD

Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>

# Conflicts:
#	src/main/java/org/gridsuite/study/server/service/StudyService.java
…-list' into feat/delete-modification-references-instead-of-stashing

Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>

# Conflicts:
#	src/main/java/org/gridsuite/study/server/service/networkmodification/NetworkModificationRestService.java
…-list' into feat/delete-modification-references-instead-of-stashing

Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…-list' into feat/delete-modification-references-instead-of-stashing

Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>

# Conflicts:
#	src/main/java/org/gridsuite/study/server/service/StudyService.java
…-list' into feat/delete-modification-references-instead-of-stashing

Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>

# Conflicts:
#	src/main/java/org/gridsuite/study/server/service/StudyService.java
…-list' into feat/delete-modification-references-instead-of-stashing

Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>

# Conflicts:
#	src/test/java/org/gridsuite/study/server/service/networkmodification/NetworkModificationServiceTest.java
…-list' into feat/delete-modification-references-instead-of-stashing
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant