Skip to content

[node-maintenance-repair/2] Show the selected batch in the native Check - #43

Open
omry wants to merge 1 commit into
pr42from
pr43
Open

omry wants to merge 1 commit into
pr42from
pr43

Conversation

@omry

@omry omry commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Reads the selected exact patch updates from a managed maintenance PR and shows them in the shared App's Dependency repair Check. The receiver fetches the canonical repository and PR, requires an open bot-authored PR from maintenance/node-security in the same repository targeting its current default branch, and writes only its own Check.

The C1 parser validates checked and unchecked rows, rejects duplicates and malformed or non-increasing same-minor patches, and preserves version strings. Shared fixtures bind sorted selections, PR number, head and base to the exact SHA-256 fingerprint. PR edits refresh an existing idle Check, including when overlapping initial deliveries created duplicates; a changed head receives a Check bound to that head. Bounded canonical rechecks reconcile edits that arrive during a Check write. Empty or invalid selections cannot expose an action.

The token stays restricted to one repository with Contents read, Pull requests read and Checks write. This slice adds no Run action, database, dispatch or dependency repair. It depends on the receiver in #42.

Validation: 96 Worker unit tests with 100% line and function coverage; native Workers receiver regression and pinned Wrangler bundle; 1,294 repository tests, Ruff, formatting and Pyrefly. Live selection and head-refresh acceptance is tracked separately for the approved deployment.


Reads the selected exact patch updates from a managed maintenance PR and shows them in the shared App's **Dependency repair** Check. The receiver fetches the canonical repository and PR, requires an open bot-authored PR from `maintenance/node-security` in the same repository targeting its current default branch, and writes only its own Check.

The C1 parser validates checked and unchecked rows, rejects duplicates and malformed or non-increasing same-minor patches, and preserves version strings. Shared fixtures bind sorted selections, PR number, head and base to the exact SHA-256 fingerprint. PR edits refresh an existing idle Check, including when overlapping initial deliveries created duplicates; a changed head receives a Check bound to that head. Bounded canonical rechecks reconcile edits that arrive during a Check write. Empty or invalid selections cannot expose an action.

The token stays restricted to one repository with Contents read, Pull requests read and Checks write. This slice adds no Run action, database, dispatch or dependency repair. It depends on the receiver in #42.

Validation: 96 Worker unit tests with 100% line and function coverage; native Workers receiver regression and pinned Wrangler bundle; 1,294 repository tests, Ruff, formatting and Pyrefly. Live selection and head-refresh acceptance is tracked separately for the approved deployment.
@omry
omry changed the base branch from main to pr42 October 23, 2026 12:06
@omry
omry added this pull request to stack #44 October 23, 2026 12:06
@omry

omry commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:acdedf6a78ce7f77b3f18bd722b5fba2ccebd48239b945f8a1ecc5b21c848617",
    "evidence": {
      "attestations": [
        {
          "closure_identity": "sha256:082856952f1b78ae3408d04fd3e1c7946d59f875b8b311c6008e4fa4a8dfaa7c",
          "document_identity": "sha256:59cc4c60e3c82a2c6d63ccc1826ff14e5cc26f89052dbb23bd864ffe8fb3f0a9",
          "sidecar_identity": "sha256:23cc87503b0b509365d991bd815ad7f2a18b3623756ceac875f9696da82802ab"
        }
      ],
      "candidate_revision_fingerprint": "sha256:acdedf6a78ce7f77b3f18bd722b5fba2ccebd48239b945f8a1ecc5b21c848617",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "repair-app",
          "run_id": 120404685095
        },
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 120404684802
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 120404685121
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 120404685075
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 120404685313
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 120404684991
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 120404685389
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 120404685332
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:05caa94be930d7928ea73cdd8027eef6f7eb17d3db5245ca490879a243feaa4e",
      "review_request": {
        "body_digest": "sha256:67e6066a1c7daf65cde5148afcf647d90af8512dc9b5cb9a28a3765d0e00cbf9",
        "id": 6364735647
      },
      "review_result": {
        "body_digest": "sha256:5f681c544ce542a1b87c6cbcfbad668f10f1587cb958553cc89ca16262192dc3",
        "id": 6364789442
      }
    },
    "evidence_fingerprint": "sha256:62fc640ed710c0e96c5015cf028a65bf7b40e0c8db01d76138d81339746160ee",
    "head_sha": "dd936dc3f352c160d9824630eb6b32ae675d3887",
    "operation_identity": "sha256:05caa94be930d7928ea73cdd8027eef6f7eb17d3db5245ca490879a243feaa4e",
    "review_request_id": 6364735647,
    "review_result_id": 6364789442,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:acdedf6a78ce7f77b3f18bd722b5fba2ccebd48239b945f8a1ecc5b21c848617",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "repair-app",
      "run_id": 120404685095
    },
    {
      "conclusion": "SUCCESS",
      "name": "test",
      "run_id": 120404684802
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, npm, 11.9.0)",
      "run_id": 120404685121
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.20.0)",
      "run_id": 120404685075
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.21.0)",
      "run_id": 120404685313
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, npm, 11.9.0)",
      "run_id": 120404684991
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.20.0)",
      "run_id": 120404685389
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.21.0)",
      "run_id": 120404685332
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "repair-app",
          "run_id": 120404685095,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39950863158/job/120404685095"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 120404684802,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39950863158/job/120404684802"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 120404685121,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39950863158/job/120404685121"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 120404685075,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39950863158/job/120404685075"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 120404685313,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39950863158/job/120404685313"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 120404684991,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39950863158/job/120404684991"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 120404685389,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39950863158/job/120404685389"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 120404685332,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39950863158/job/120404685332"
        }
      ],
      "head_sha": "dd936dc3f352c160d9824630eb6b32ae675d3887",
      "id": "sha256:ed52bfe85ccc7874370c7e9157394e3057c5c6d51f7622133fbc7fc011db1416",
      "required_checks": [
        "repair-app",
        "test",
        "toolchain (22, npm, 11.9.0)",
        "toolchain (22, pnpm, 11.20.0)",
        "toolchain (22, pnpm, 11.21.0)",
        "toolchain (24, npm, 11.9.0)",
        "toolchain (24, pnpm, 11.20.0)",
        "toolchain (24, pnpm, 11.21.0)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "pr42",
    "base_sha": "6009198151028e1d42d6f26a76545852d6553c2e",
    "body_digest": "sha256:c26548b62e3c37532eecd0c87a70fb22edd8812025257f2ad91a9803722a2916",
    "diff_digest": "sha256:9480e7e2f382d280f315c059756d47623d21c3a8c8aa35c9bfa870a93c29980f",
    "head_ref": "pr43",
    "head_sha": "dd936dc3f352c160d9824630eb6b32ae675d3887",
    "pr": 43,
    "repository": "hydra-ecosystem/github-actions",
    "scope_authority": [],
    "title_digest": "sha256:3bb1ced5ff2ac3075e2ecddbd815db43d733720f7a36bc7c8f6924afbd7351c1"
  },
  "record_version": 4,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-10-23T12:06:29Z",
      "base_ref": "pr42",
      "base_sha": "6009198151028e1d42d6f26a76545852d6553c2e",
      "body_digest": "sha256:67e6066a1c7daf65cde5148afcf647d90af8512dc9b5cb9a28a3765d0e00cbf9",
      "created_at": "2026-10-23T12:20:43Z",
      "head_sha": "dd936dc3f352c160d9824630eb6b32ae675d3887",
      "id": 6364735647,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr42",
      "base_sha": "6009198151028e1d42d6f26a76545852d6553c2e",
      "body_digest": "sha256:5f681c544ce542a1b87c6cbcfbad668f10f1587cb958553cc89ca16262192dc3",
      "commit_id": "dd936dc3f352c160d9824630eb6b32ae675d3887",
      "id": 6364789442,
      "inline_message_ids": [],
      "request_comment_id": 6364735647,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-10-23T12:23:47Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:acdedf6a78ce7f77b3f18bd722b5fba2ccebd48239b945f8a1ecc5b21c848617",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:9480e7e2f382d280f315c059756d47623d21c3a8c8aa35c9bfa870a93c29980f",
      "finding_ids": [],
      "invariants": [],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "dd936dc3f352c160d9824630eb6b32ae675d3887",
      "review_observation_id": null,
      "review_request_id": 6364735647,
      "review_result_id": 6364789442,
      "reviewed_head": "dd936dc3f352c160d9824630eb6b32ae675d3887",
      "root_cause": null,
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review October 23, 2026 12:16
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T12:23:48.746426Z dd936dc Manual request
🔒 Security Review ✅ Completed 2026-10-23T12:20:20.492353Z dd936dc Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Exact head: dd936dc

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: dd936dc3f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant