Skip to content

[node-maintenance-repair/6] Prepare and seal one bounded candidate - #49

Open
omry wants to merge 1 commit into
pr48from
pr49
Open

omry wants to merge 1 commit into
pr48from
pr49

Conversation

@omry

@omry omry commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Recheck the managed PR's canonical repository, exact revisions and selected patch batch before preparing a candidate with read-only permissions. Reuse the existing project and audit engines to verify retained pins, compatible published targets, parent/direct constraints and release cooldown.

Disable project lifecycle and pnpmfile hooks during metadata, audit and lock-only resolution. Isolate parser installation from checkout-owned Python modules. Preserve unrelated policy, lock data and peer suffixes, and export with external diff and text conversion disabled.

Seal exactly candidate.patch, a request/project-bound audit.json envelope, and the shared preparation-only result.md. Expose the immutable artifact ID through guard/prepare-only reusable workflow wiring. Document the isolated acceptance boundary; validation, publication and rollout remain later slices.

Validation: 1,427 Python tests, Ruff lint/format, Pyrefly, and retained real pnpm 11.20.0/11.21.0 hook/scope probes. Hosted preparation acceptance remains pending.


Recheck the managed PR's canonical repository, exact revisions and selected patch batch before preparing a candidate with read-only permissions. Reuse the existing project and audit engines to verify retained pins, compatible published targets, parent/direct constraints and release cooldown.

Disable project lifecycle and pnpmfile hooks during metadata, audit and lock-only resolution. Isolate parser installation from checkout-owned Python modules. Preserve unrelated policy, lock data and peer suffixes, and export with external diff and text conversion disabled.

Seal exactly candidate.patch, a request/project-bound audit.json envelope, and the shared preparation-only result.md. Expose the immutable artifact ID through guard/prepare-only reusable workflow wiring. Document the isolated acceptance boundary; validation, publication and rollout remain later slices.

Validation: 1,427 Python tests, Ruff lint/format, Pyrefly, and retained real pnpm 11.20.0/11.21.0 hook/scope probes. Hosted preparation acceptance remains pending.
@omry
omry changed the base branch from main to pr48 October 25, 2026 10:57
@omry
omry added this pull request to stack #44 October 25, 2026 10:57
@omry

omry commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:50ad3615de373e7fd74ffbdfa34afbc0759dfe84fdde672ea1f165e9b0d24912",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:50ad3615de373e7fd74ffbdfa34afbc0759dfe84fdde672ea1f165e9b0d24912",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "repair-app",
          "run_id": 121149360803
        },
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 121149360622
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 121149360944
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 121149360884
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 121149360833
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 121149360958
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 121149360995
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 121149360841
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:f369c76252f8b716dfca7fbfde9fb69a16f54a851fb9ba2817a25cafc335a79d",
      "review_request": {
        "body_digest": "sha256:a662d74d1502d08befb25786bd175825431206db9cc25bd7f044f470dba7c7c3",
        "id": 6396884347
      },
      "review_result": {
        "body_digest": "sha256:6bf4d768f8932cf6e4f3be859125ad619efd2f839912444b0fc8ac2822505867",
        "id": 6397439081
      }
    },
    "evidence_fingerprint": "sha256:c7062b5401505ee9e535c1bb93e998acd772b6dc5caf51b25272bb25736775f1",
    "head_sha": "77294b363a80d8ede22f945de1a9d36c22df8d90",
    "operation_identity": "sha256:f369c76252f8b716dfca7fbfde9fb69a16f54a851fb9ba2817a25cafc335a79d",
    "review_request_id": 6396884347,
    "review_result_id": 6397439081,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:50ad3615de373e7fd74ffbdfa34afbc0759dfe84fdde672ea1f165e9b0d24912",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "repair-app",
      "run_id": 121149360803
    },
    {
      "conclusion": "SUCCESS",
      "name": "test",
      "run_id": 121149360622
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, npm, 11.9.0)",
      "run_id": 121149360944
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.20.0)",
      "run_id": 121149360884
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.21.0)",
      "run_id": 121149360833
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, npm, 11.9.0)",
      "run_id": 121149360958
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.20.0)",
      "run_id": 121149360995
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.21.0)",
      "run_id": 121149360841
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "repair-app",
          "run_id": 121149360803,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40186851122/job/121149360803"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 121149360622,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40186851122/job/121149360622"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 121149360944,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40186851122/job/121149360944"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 121149360884,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40186851122/job/121149360884"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 121149360833,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40186851122/job/121149360833"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 121149360958,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40186851122/job/121149360958"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 121149360995,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40186851122/job/121149360995"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 121149360841,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40186851122/job/121149360841"
        }
      ],
      "head_sha": "77294b363a80d8ede22f945de1a9d36c22df8d90",
      "id": "sha256:e15cbc06833bdc20ef424053aab92338862ef95eaf411f3c0ab447a8bcb41583",
      "required_checks": [
        "repair-app",
        "test",
        "toolchain (22, npm, 11.9.0)",
        "toolchain (22, pnpm, 11.20.0)",
        "toolchain (22, pnpm, 11.21.0)",
        "toolchain (24, npm, 11.9.0)",
        "toolchain (24, pnpm, 11.20.0)",
        "toolchain (24, pnpm, 11.21.0)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "pr48",
    "base_sha": "f37ec4f2a513c063563a3488f1e905309efd7c0b",
    "body_digest": "sha256:2571745786e0d2aca228a0ca4e6787dd59071a567f4cba8580d9baae3992e20d",
    "body_identity_version": 2,
    "diff_digest": "sha256:f19b1f63583ddd8c645dfd14522911993ee89cbaa708039d8d03dd3a2f312a6f",
    "head_ref": "pr49",
    "head_sha": "77294b363a80d8ede22f945de1a9d36c22df8d90",
    "pr": 49,
    "repository": "hydra-ecosystem/github-actions",
    "scope_authority": [
      {
        "digest": "sha256:e8a1d042e9162180df2fb9f0643a81a04b06327116c444b942c3b2a9f7f45cdf",
        "path": ".github/workflows/validate.yml"
      },
      {
        "digest": "sha256:4e1af4fc1733aab85da509e5e3142829be05695ad41873adef8d2fe5930292c0",
        "path": "README.md"
      },
      {
        "digest": "sha256:b60d30b53b42d9c2c18eae03e05af25cb4e91e737de079477d58e2ed93576ddb",
        "path": "node/contract.json"
      }
    ],
    "title_digest": "sha256:22badaf68a37ce5e625c3fd82b0e519f88b4d8fca7da10f879e6f3f7aa0addd4"
  },
  "record_version": 6,
  "review_observations": [
    {
      "base_ref": "pr48",
      "base_sha": "f37ec4f2a513c063563a3488f1e905309efd7c0b",
      "evidence_digest": "sha256:498ba7047aef1b3ff1fd1f5d9712418cd01cfad462c2ce2017c5d4f04d523b59",
      "head_sha": "77294b363a80d8ede22f945de1a9d36c22df8d90",
      "id": "sha256:040716df8b14c693d8862ced5d1fabef50a80e6317c9baa5c31809f13cccfe0b",
      "poll": {
        "completed_at": "2026-10-25T11:57:02.604Z",
        "elapsed_seconds": 2704.35,
        "observations": 83,
        "started_at": "2026-10-25T11:09:09.707Z"
      },
      "request_comment_id": 6396884347,
      "status": "timeout"
    }
  ],
  "review_requests": [
    {
      "base_established_at": "2026-10-25T10:57:06Z",
      "base_ref": "pr48",
      "base_sha": "f37ec4f2a513c063563a3488f1e905309efd7c0b",
      "body_digest": "sha256:a662d74d1502d08befb25786bd175825431206db9cc25bd7f044f470dba7c7c3",
      "created_at": "2026-10-25T11:09:46Z",
      "head_sha": "77294b363a80d8ede22f945de1a9d36c22df8d90",
      "id": 6396884347,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr48",
      "base_sha": "f37ec4f2a513c063563a3488f1e905309efd7c0b",
      "body_digest": "sha256:6bf4d768f8932cf6e4f3be859125ad619efd2f839912444b0fc8ac2822505867",
      "commit_id": "77294b363a80d8ede22f945de1a9d36c22df8d90",
      "id": 6397439081,
      "inline_message_ids": [],
      "request_comment_id": 6396884347,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-10-25T12:08:21Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:50ad3615de373e7fd74ffbdfa34afbc0759dfe84fdde672ea1f165e9b0d24912",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:f19b1f63583ddd8c645dfd14522911993ee89cbaa708039d8d03dd3a2f312a6f",
      "finding_ids": [],
      "invariants": [],
      "outcome": "timeout",
      "proposed_fix_paths": [],
      "resulting_head": "77294b363a80d8ede22f945de1a9d36c22df8d90",
      "review_observation_id": "sha256:040716df8b14c693d8862ced5d1fabef50a80e6317c9baa5c31809f13cccfe0b",
      "review_request_id": 6396884347,
      "review_result_id": null,
      "reviewed_head": "77294b363a80d8ede22f945de1a9d36c22df8d90",
      "root_cause": null,
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    },
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:f19b1f63583ddd8c645dfd14522911993ee89cbaa708039d8d03dd3a2f312a6f",
      "finding_ids": [],
      "invariants": [],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "77294b363a80d8ede22f945de1a9d36c22df8d90",
      "review_observation_id": null,
      "review_request_id": 6396884347,
      "review_result_id": 6397439081,
      "reviewed_head": "77294b363a80d8ede22f945de1a9d36c22df8d90",
      "root_cause": null,
      "round": 2,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review October 25, 2026 11:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T12:08:23.266839Z 77294b3 Manual request
🔒 Security Review ✅ Completed 2026-10-25T11:10:16.496484Z 77294b3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Exact head: 77294b3

1 similar comment
@omry

omry commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Exact head: 77294b3

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 77294b363a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant