Repository navigation
test(logging): fix Octad banner substring casing (unbreak cargo test on main) - #218
Merged
Merged
Conversation
The banner prints "VeriSimiser Octad" (the product spelling) but the assertion added in the previous commit checked "Verisimiser Octad", so cargo test failed on main. Assert the real string. Refs #213. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 46 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
force-pushed
the
arena/83f35903-verisimiser
branch
from
October 24, 2026 10:54
076904e to
d210b49
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
hyperpolymath
added a commit
that referenced
this pull request
Oct 25, 2026
…template placeholders and phantom recipes) (#219) Follow-up to #217 / #218, prompted by trying to follow the install instructions in this repo. ## The problem `QUICKSTART-DEV.adoc`, `QUICKSTART-USER.adoc`, `QUICKSTART-MAINTAINER.adoc` and `docs/QUICKSTART.adoc` were **unfilled RSR templates**. Following them produced: * literal `{{LANG_STACK}}`, `{{BUILD_CMD}}`, `{{TEST_CMD}}`, `{{DEPS}}`, `{{MUST_INVARIANTS}}` placeholders; * `just setup`, `just setup-dev`, `just e2e`, `just check-error-codes`, `just panic-scan`, `just llm-context`, `just build-release`, `just stapeln-*`, `just uninstall` — **none of these recipes exist** (`just --list` is the real set); there is also no error-code catalogue anywhere in the tree; * `just install --prefix=/usr/local` — the recipe takes no arguments; * "Container (via Stapeln)" / `podman build` presented as working, though `Containerfile` is a template with commented-out `TODO` build steps and unreplaced metadata; * `nix develop` though there is **no `flake.nix`**; * the expected first-run output "Verisimiser started successfully." — the CLI's `start` subcommand is a placeholder and prints nothing of the kind. ## Fix Rewritten from a clone of the repo, not from the template: * **Setup** — `rustup --profile minimal` (that part of the instruction was right) plus `rustup component add clippy rustfmt`, since `--profile minimal` ships neither and `just quality` needs both. MSRV 1.85 / edition 2024; `rusqlite` bundles SQLite, so a C compiler is required and there is no `libsqlite3` runtime dep; `just` is optional (`cargo fetch` instead of `just setup`). * **Install** — `cargo install --path .` → `~/.cargo/bin/verisimiser`; `cargo build --release` → `target/release/verisimiser`; `cargo install --path . --root <prefix>` for a custom prefix. Notes that no release/tag exists yet, so source build is the only route. * **Test** — `just test`, the CI-parity form `cargo test --all-targets --no-fail-fast`, and the real suite layout (5 files / 23 integration tests / 146 unit `#[test]`s, CLI tests via `CARGO_BIN_EXE_verisimiser`). Explicitly says there is no separate e2e command. * **Maintainer** — packaging via `cargo install --root`, the fact that exactly one file gets installed, no global/XDG config (the manifest path *is* the config), multi-instance pattern, `gc`/`status --json` for operations, and a "what is not packaging-ready" section. * **Honest status** — Containerfile/devcontainer are template stubs, no `flake.nix`, `guix.scm` is a dev shell pinned to 0.1.0 while `Cargo.toml` is 0.2.0, Tier 2 is stubs, PostgreSQL runtime reads refuse. ## Guard against recurrence * `scripts/check-doc-recipes.sh` + **`just doc-recipes`**: scans `.adoc` code blocks for `just <name>` and fails on any recipe not defined in `Justfile`/`*.just`. Sync-managed template artifacts that describe the template's own recipes are reported and skipped rather than rewritten. * `CONTRIBUTING-DEV.adoc` gains **"Commands in docs must exist"**, with a non-recipe → real-alternative table and the rule from ADR-0002: fix the docs, don't invent a recipe. ## Also * `README.adoc` build section: `Containerfile` no longer described as producing a working image, and "pre-built release binaries are published" softened to "workflow exists; no release published yet". * `TEST-NEEDS.adoc`: dropped the `/var/mnt/eclipse/repos/verisimiser` path, refreshed counts, noted `proptest` is declared but unused and `tests/fuzz/` is a placeholder. * `llm-warmup-{dev,user}.adoc` and the `setup.sh` header no longer point at `just setup`. ## Verification * `just doc-recipes` → **passes**; confirmed it **fails** on a probe file containing `just e2e` / `just check-error-codes`. * All edited `.adoc` render with Asciidoctor with **zero warnings** (Node `asciidoctor@3`); every table is well-formed. * No Rust or workflow behaviour changed — `Justfile` gains one recipe, `setup.sh` only a comment. `cargo` is unavailable in this sandbox, so `cargo test` was not run locally; the earlier `cargo test` fix already landed in #218 and main is green. Deliberately **not** touched: the sync-managed template files (`docs/RSR_OUTLINE.adoc`, `container/*`, `.machine_readable/**`) whose stale recipe references belong upstream in `hyperpolymath/standards`. --------- Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #217 (merged as 739afc4).
The previous commit changed the
verisimiser octadbanner to=== VeriSimiser Octad: Eight Concerns ===but asserted"Verisimiser Octad"(lowercases) intests/logging_test.rs. The substring never matches, so cargo test (stable) / (1.85) fail on main.This corrects the assertion to the real string. Test intent is unchanged: the
octadtable is data output on stdout, and the banner names VeriSimiser's concern Octad rather than VeriSimDB's upstream modality Octad (ADR-0014).Only
tests/logging_test.rschanges.