fix(webview): handle fast-mode guard bundle drift#323
Closed
mkaoudis wants to merge 1 commit into
Closed
Conversation
This was referenced May 27, 2026
Owner
|
Thanks for putting this together. We are going to close this PR because the fast-mode guard drift has already been fixed on The failing Nix check here was not caused by this patch; it was the older upstream app version pin mismatch. However, the branch is now draft/conflicting and the functional fix has already landed, so keeping this PR open would only duplicate the current Thanks again for catching the upstream bundle drift. |
Contributor
Author
|
No problem! Happy to contribute when I run into stuff, thanks for reviewing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review order
This PR should be reviewed after #322. The code change itself is independent, but its Nix check is currently red only because main lacks #322's PR-only upstream DMG rollout handling. Once #322 lands, this PR should go green after rebase or rerun.
User-visible behavior
Linux app builds from the current upstream DMG should no longer fail required upstream patch validation because of the fast-mode guard shape.
Source of truth
Validation
Local validation:
GitHub validation on this draft PR:
Known scope
This only fixes the fast-mode required patch drift. It intentionally leaves unrelated remote-mobile and subagent drift handling to separate focused changes.