Skip to content

fix(ci): tolerate upstream DMG rollout in PR Nix checks#322

Merged
ilysenko merged 2 commits into
ilysenko:mainfrom
mkaoudis:fix/nix-pr-upstream-rollout
May 27, 2026
Merged

fix(ci): tolerate upstream DMG rollout in PR Nix checks#322
ilysenko merged 2 commits into
ilysenko:mainfrom
mkaoudis:fix/nix-pr-upstream-rollout

Conversation

@mkaoudis
Copy link
Copy Markdown
Contributor

@mkaoudis mkaoudis commented May 27, 2026

Summary

  • keep Nix package CI strict for main-branch and non-DMG failures
  • allow pull-request CI to skip package-output builds when upstream Codex.dmg metadata or fixed-output hash drift is detected during rollout
  • serialize Nix package-output builds and collect garbage between outputs to reduce runner store pressure

Review order

This is the first PR in the small CI-fix stack and is ready for maintainer review from my side. Follow-up #323 depends on this behavior to get its otherwise unrelated Nix check green during the current upstream DMG rollout.

User-visible behavior

No shipped package behavior changes. This only changes GitHub Actions behavior for PR-only upstream DMG rollout windows.

Source of truth

  • .github/workflows/ci.yml

Validation

Local validation:

  • python3 workflow YAML parse for .github/workflows/*.yml
  • bash -n scripts/ci/validate-nix-pins.sh
  • git diff --check origin/main...HEAD

GitHub validation on this PR:

  • Rust and Smoke Tests: pass
  • Build Debian Package: pass
  • Build RPM Package: pass
  • Build Pacman Package: pass
  • Nix Package Builds: pass

Known scope

This intentionally does not refresh committed Nix pins. Main-branch validation still fails on drift so the scheduled hash-refresh workflow remains responsible for updating pins.

Copy link
Copy Markdown
Owner

@ilysenko ilysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the updated head. CI is green and the rollout skip is now guarded so pin-file PRs stay strict.

@ilysenko ilysenko merged commit 13cd316 into ilysenko:main May 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants