Update for Improv 2.4 commands/capabilities#32
Open
yinzara wants to merge 4 commits into
Open
Conversation
yinzara
commented
Dec 27, 2025
| static const uint8_t CAPABILITY_GET_WIFI_NETWORKS = 1 << 2; | ||
| static const uint8_t CAPABILITY_HOSTNAME = 1 << 3; | ||
| static const uint8_t CAPABILITY_DEVICE_NAME = 1 << 4; | ||
| static const uint8_t IMPROV_SERIAL_VERSION = 1; |
Author
There was a problem hiding this comment.
Leaving the serial version unchanged for now but this may change in the future.
kbx81
added a commit
to kbx81/sdk-cpp
that referenced
this pull request
Jun 16, 2026
Per the Improv spec, the capabilities bitmask reports which RPC commands a
device supports. This reworks the connectivity reporting so it doesn't overload
that bitmask:
- Rename the command GET_CAPABILITIES -> GET_NETWORK_STATE (0x07).
- Replace the extended capability bits with a separate NetworkState enum
(NETWORK_IS_ONLINE + present interfaces NETWORK_SUPPORTS_WIFI/ETHERNET/THREAD/
MODEM), restoring CAPABILITY_IDENTIFY as the lone capability constant.
Keeps connectivity ("is it online, what interfaces") distinct from capabilities
("which commands are supported"), and avoids colliding with the in-flight
Improv 2.4 capabilities work (improv-wifi#32).
kbx81
added a commit
to kbx81/sdk-cpp
that referenced
this pull request
Jun 16, 2026
Per the Improv spec, the capabilities bitmask reports which RPC commands a
device supports. This reworks the connectivity reporting so it doesn't overload
that bitmask:
- Rename the command GET_CAPABILITIES -> GET_NETWORK_STATE (0x07).
- Replace the extended capability bits with a separate NetworkState enum
(NETWORK_IS_ONLINE + present interfaces NETWORK_SUPPORTS_WIFI/ETHERNET/THREAD/
MODEM), restoring CAPABILITY_IDENTIFY as the lone capability constant.
Keeps connectivity ("is it online, what interfaces") distinct from capabilities
("which commands are supported"), and avoids colliding with the in-flight
Improv 2.4 capabilities work (improv-wifi#32).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.