Skip to content

Fix: Circleci pipeline failures#601

Merged
GSVarsha merged 2 commits into
otel_migrationfrom
fix_starlette_import
Aug 29, 2024
Merged

Fix: Circleci pipeline failures#601
GSVarsha merged 2 commits into
otel_migrationfrom
fix_starlette_import

Conversation

@GSVarsha

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
…done

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha requested review from CagriYonca and pvital August 28, 2024 16:14
@GSVarsha GSVarsha added this to the H2-2024 milestone Aug 28, 2024
@GSVarsha GSVarsha self-assigned this Aug 28, 2024
@GSVarsha GSVarsha added bug Review & Merge OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry labels Aug 28, 2024

@CagriYonca CagriYonca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit 863e2e3 into otel_migration Aug 29, 2024
@GSVarsha GSVarsha deleted the fix_starlette_import branch August 29, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry Review & Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants