Skip to content

Fix: Circleci pipeline failures #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GSVarsha merged 2 commits into from
Aug 29, 2024
Merged

Fix: Circleci pipeline failures #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58c4398
fix: starlette import error
GSVarsha Aug 28, 2024
6f5d318
fix(circleci): exclude google cloud jobs till the instrumentation is …
GSVarsha Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,8 @@ workflows:
# - py39cassandra
# - py39couchbase
# - py39gevent_starlette
- py311googlecloud
- py312googlecloud
# - py311googlecloud
# - py312googlecloud
- final_job:
requires:
- python38
Expand All @@ -380,5 +380,5 @@ workflows:
# - py39cassandra
# - py39couchbase
# - py39gevent_starlette
- py311googlecloud
- py312googlecloud
# - py311googlecloud
# - py312googlecloud
4 changes: 2 additions & 2 deletions src/instana/instrumentation/starlette_inst.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,11 @@

from typing import Any, Callable, Dict, Tuple

import starlette.applications

try:
import starlette
import wrapt
from starlette.middleware import Middleware
import starlette.applications

from instana.instrumentation.asgi import InstanaASGIMiddleware
from instana.log import logger
Expand All @@ -34,5 +33,6 @@ def init_with_instana(
return wrapped(*args, **kwargs)

logger.debug("Instrumenting Starlette")

except ImportError:
pass