fix(ui-dialog): allow consumers to override inherited border-radius#2595
Open
HerrTopi wants to merge 1 commit into
Open
fix(ui-dialog): allow consumers to override inherited border-radius#2595HerrTopi wants to merge 1 commit into
HerrTopi wants to merge 1 commit into
Conversation
The dialog forced `border-radius: inherit` via an inline style so that content like Menu and DateInput could inherit a wrapping View's radius. Inline styles (and an equivalent emotion `css` rule) cannot be overridden by a consumer's own `css` prop, so components like Modal could not set their own border-radius. Wrap the `inherit` rule in an `@layer` cascade layer instead. Unlayered consumer styles always win over layered ones regardless of specificity or source order, so an explicit border-radius from Modal takes effect while the inherit fallback still applies when no radius is provided. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Visual regression report✅ No changes.
Baselines come from the |
HerrTopi
requested review from
git-nandor and
matyasf
and removed request for
git-nandor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
border-radius: inheritwith an@layer-wrapped emotion rule so unlayered consumer styles (e.g. Modal) can override it while the inherit fallback still applies when none is set.Test Plan
border-radius(not the wrapping container's).Viewstill inherit the View's corner radius.Fixes INSTUI-5068
🤖 Generated with Claude Code