Skip to content

fix(ui-dialog): allow consumers to override inherited border-radius #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HerrTopi wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

fix(ui-dialog): allow consumers to override inherited border-radius #2595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/ui-dialog/src/Dialog/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
*/

import { Component } from 'react'
import { css } from '@emotion/react'

import { omitProps, getElementType } from '@instructure/ui-react-utils'
import { findDOMNode, requestAnimationFrame } from '@instructure/ui-dom-utils'
Expand Down Expand Up @@ -173,7 +174,11 @@ class Dialog extends Component<DialogProps> {
role === 'dialog' && this.props.shouldContainFocus ? true : undefined
}
className={this.props.className} // TODO in V2 remove className, there is no usage of it.
style={{ borderRadius: 'inherit' }} // ensure the dialog inherits border radius from View
css={css`
@layer dialogBase {
& { border-radius: inherit; }
}
`} //making sure it inherits from containers if nothing is specified from outside and use the outside specifiers if they are present, e.g.:modal
ref={this.getRef}
>
{this.props.children}
Expand Down
Loading