qat_init: fix qat.service timeout with multiple drivers#151
Merged
Conversation
gcabiddu
approved these changes
Apr 30, 2026
Contributor
|
On the commit message, can we use the format |
When multiple QAT drivers are loaded (e.g. qat_4xxx and
qat_420xx), get_module_state() returns one "Live" line per
module. The check_driver() comparison:
while [ "$CURRENT_STATE" != "Live" ]
fails because "Live\nLive" never equals "Live", causing
qat_init to loop until the 20-second timeout and abort.
Add sort -u to deduplicate the module state output so that
when all loaded drivers report "Live", the result collapses
to a single "Live" and the comparison succeeds. If any
module is in a different state, the deduplicated output
remains multi-line and the wait loop continues correctly.
Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
Ahsan-Atta
changed the title
Contributor
Author
done. |
gcabiddu
approved these changes
Apr 30, 2026
fionatrahe
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple QAT drivers are loaded (e.g. qat_4xxx and qat_420xx), get_module_state() returns one "Live" line per module. The check_driver() comparison:
fails because "Live\nLive" never equals "Live", causing qat_init to loop until the 20-second timeout and abort.
Add sort -u to deduplicate the module state output so that when all loaded drivers report "Live", the result collapses to a single "Live" and the comparison succeeds. If any module is in a different state, the deduplicated output remains multi-line and the wait loop continues correctly.