chore(vercel): use absolute hrefs in preview dir indexes#31106
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
generate_dir_indexincore/scripts/vercel-build.shwrites child links like<a href="basic/">and an up-link<a href="../">. Vercel doesn't 308-redirect to add a trailing slash, so visiting a preview directory URL like/src/components/progress-bar/test(no slash) returns the index page but the browser resolvesbasic/against the parent directory. That path doesn't exist, and Vercel's fallback serves the root landing page, so navigation looks like it "circles back" to the preview home instead of opening the test scenario.What is the new behavior?
The dir-index generator now emits absolute hrefs based on the directory's
url_path, including the../up-link. Trailing-slash quirks no longer affect navigation between component test scenarios on Vercel previews.Does this introduce a breaking change?
Other information
Test page:
Versus the broken version on main: