Skip to content

chore(vercel): use absolute hrefs in preview dir indexes #31106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShaneK merged 1 commit into from
Apr 30, 2026
Merged

chore(vercel): use absolute hrefs in preview dir indexes #31106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions core/scripts/vercel-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ generate_dir_index() {
# Skip if an index.html already exists (it's an actual test page)
[ -f "${dir}/index.html" ] && return

# Absolute hrefs based on url_path. Vercel does not redirect to add trailing
# slashes, so a relative href like "basic/" from a URL without a trailing
# slash resolves against the parent directory and breaks navigation.
local parent_path="${url_path%/}"
parent_path="${parent_path%/*}/"

local entries=""
for child in "${dir}"/*/; do
[ -d "${child}" ] || continue
Expand All @@ -70,7 +76,7 @@ generate_dir_index() {
case "${name}" in *-snapshots|.*) continue ;; esac
# Only include if there's at least one index.html somewhere underneath
find "${child}" -name "index.html" -print -quit | grep -q . || continue
entries="${entries}<a href=\"${name}/\">${name}/</a>\n"
entries="${entries}<a href=\"${url_path}${name}/\">${name}/</a>\n"
done

[ -z "${entries}" ] && return
Expand All @@ -92,7 +98,7 @@ generate_dir_index() {
</head>
<body>
<h1>Index of ${url_path}</h1>
<a class="up" href="../">../</a>
<a class="up" href="${parent_path}">../</a>
$(echo -e "${entries}")
</body>
</html>
Expand Down
Loading