Conversation
krglkvrmn
reviewed
Mar 6, 2022
krglkvrmn
left a comment
krglkvrmn
left a comment
There was a problem hiding this comment.
Хорошая работа, +1 балл за список зависимостей
| class RNA: | ||
|
|
||
| def __init__(self, rna): | ||
| self.rna = Seq(rna) |
There was a problem hiding this comment.
Нужны проверки на алфавит, иначе Seq съест почти что угодно
Comment on lines
+59
to
+60
| self.positive_numbers = [arg for arg in args if isinstance(arg, (int, float)) and arg > 0] | ||
| super().__init__(self.positive_numbers) |
There was a problem hiding this comment.
Записывать это в атрибут не нужно
Suggested change
| self.positive_numbers = [arg for arg in args if isinstance(arg, (int, float)) and arg > 0] | |
| super().__init__(self.positive_numbers) | |
| positive_numbers = [arg for arg in args if isinstance(arg, (int, float)) and arg > 0] | |
| super().__init__(positive_numbers) |
Comment on lines
+105
to
+106
| with open(self.path) as f: | ||
| for record in SeqIO.parse(f, "fasta"): |
There was a problem hiding this comment.
Ты считываешь данные в каждой функции. Наверное, лучше выделить это в отдельный метод и считать всё один раз в конструкторе
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.