Skip to content

test: use RFC 2606 reserved domains in all test fixtures#49

Merged
turegjorup merged 2 commits into
developfrom
test/rfc2606-fixture-domains
Jun 11, 2026
Merged

test: use RFC 2606 reserved domains in all test fixtures#49
turegjorup merged 2 commits into
developfrom
test/rfc2606-fixture-domains

Conversation

@turegjorup

Copy link
Copy Markdown
Contributor

Summary

Replaces every invented-but-registrable domain in the test fixtures with RFC 2606 reserved names, using subdomains for readability:

  • provider.example.org — IdP-side URLs (metadata_url, authorization endpoint); a second provider in the multi-provider test uses other-provider.example.org
  • app.example.org — application-side URLs (redirect_uri/callbacks, CLI login page)
  • test@example.org — test account email

Domains removed: app.com (13×), provider.com (2×), other.com, test.com (incl. test@test.com).

Files Changed

  • tests/config/itkdev_openid_connect.yml - provider metadata + redirect URIs
  • tests/Security/OpenIdConfigurationProviderManagerTest.php - callback URIs
  • tests/Security/OpenIdLoginAuthenticatorTest.php - test email
  • tests/DependencyInjection/ConfigurationTest.php - redirect URIs + second provider metadata URL
  • tests/Controller/LoginControllerTest.php - IdP authorization URL
  • tests/Command/UserLoginCommandTest.php - CLI login URL (same change as test: pin down CLI login token lifecycle and URL generation #47; identical on both sides, so merges cleanly in either order)
  • CHANGELOG.md - Unreleased bullet

Test Plan

  • vendor/bin/phpunit — 83 tests, 184 assertions, green
  • PHPStan max level, markdownlint, prettier (yaml) — clean
  • grep -rE 'app\.com|provider\.com|other\.com|test\.com' tests/ src/ README.md — no matches

Notes

🤖 Generated with Claude Code

Replace real registrable domains (app.com, provider.com, other.com,
test.com) with reserved names: provider.example.org for IdP-side URLs
(metadata, authorization endpoint) and app.example.org for
application-side URLs (redirect/callback, CLI login page).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codecov-commenter

codecov-commenter commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (79e62dc) to head (40681bc).

Additional details and impacted files
@@             Coverage Diff             @@
##             develop       #49   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        62        62           
===========================================
  Files              9         9           
  Lines            282       282           
===========================================
  Hits             282       282           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@turegjorup turegjorup self-assigned this Jun 11, 2026
…re-domains

# Conflicts:
#	CHANGELOG.md
#	tests/Command/UserLoginCommandTest.php
#	tests/Security/OpenIdConfigurationProviderManagerTest.php
#	tests/Security/OpenIdLoginAuthenticatorTest.php
@turegjorup turegjorup merged commit 5e74d38 into develop Jun 11, 2026
16 checks passed
@turegjorup turegjorup deleted the test/rfc2606-fixture-domains branch June 11, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants