test: use RFC 2606 reserved domains in all test fixtures#49
Merged
Conversation
Replace real registrable domains (app.com, provider.com, other.com, test.com) with reserved names: provider.example.org for IdP-side URLs (metadata, authorization endpoint) and app.example.org for application-side URLs (redirect/callback, CLI login page). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #49 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 62 62
===========================================
Files 9 9
Lines 282 282
===========================================
Hits 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…re-domains # Conflicts: # CHANGELOG.md # tests/Command/UserLoginCommandTest.php # tests/Security/OpenIdConfigurationProviderManagerTest.php # tests/Security/OpenIdLoginAuthenticatorTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces every invented-but-registrable domain in the test fixtures with RFC 2606 reserved names, using subdomains for readability:
provider.example.org— IdP-side URLs (metadata_url, authorization endpoint); a second provider in the multi-provider test usesother-provider.example.orgapp.example.org— application-side URLs (redirect_uri/callbacks, CLI login page)test@example.org— test account emailDomains removed:
app.com(13×),provider.com(2×),other.com,test.com(incl.test@test.com).Files Changed
tests/config/itkdev_openid_connect.yml- provider metadata + redirect URIstests/Security/OpenIdConfigurationProviderManagerTest.php- callback URIstests/Security/OpenIdLoginAuthenticatorTest.php- test emailtests/DependencyInjection/ConfigurationTest.php- redirect URIs + second provider metadata URLtests/Controller/LoginControllerTest.php- IdP authorization URLtests/Command/UserLoginCommandTest.php- CLI login URL (same change as test: pin down CLI login token lifecycle and URL generation #47; identical on both sides, so merges cleanly in either order)CHANGELOG.md- Unreleased bulletTest Plan
vendor/bin/phpunit— 83 tests, 184 assertions, greengrep -rE 'app\.com|provider\.com|other\.com|test\.com' tests/ src/ README.md— no matchesNotes
example.commetadata URLs (already RFC 2606-compliant) were left unchanged🤖 Generated with Claude Code