Fix typo serialization key in AbstractCinematicEven (Issue #2449)#2668
Merged
riccardobl merged 2 commits intojMonkeyEngine:masterfrom Mar 30, 2026
Merged
Fix typo serialization key in AbstractCinematicEven (Issue #2449)#2668riccardobl merged 2 commits intojMonkeyEngine:masterfrom
riccardobl merged 2 commits intojMonkeyEngine:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in the serialization key for 'initialDuration' and implements backward compatibility to support the previous misspelled key 'initalDuration'. The review feedback suggests simplifying the fallback logic by nesting the read calls, which removes the need for magic numbers and improves code readability.
jme3-core/src/main/java/com/jme3/cinematic/events/AbstractCinematicEvent.java
Outdated
Show resolved
Hide resolved
Simplifies the previous code in the `read(...)` function on class `AbstractCinematicEvent`. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the issue #2449 stated. The serialization key, for the class's field
initialDuration, should has beeninitialDurationbutinitalDurationwas written. To fix it and, at the same time, avoid the backward incompatibility:writefunction: The key is always correctly setted as initialDuration.readfunction: First, it checks forinitialDurationkey, if not found, it uses the default value to indicate that it was not found. Then, the same it does withinitalDuration. If none is found the class fieldinitialDurationis set with the original default value, which is 10. I thought about using the value -1 as indicator of not finding the key since it shouldn't make sense negative temporal units for this field. Also added a commentary to indicate why a double check was occurring for future readers.close #2449