Skip to content

Fix typo serialization key in AbstractCinematicEven (Issue #2449) #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riccardobl merged 2 commits into from
Mar 30, 2026
+3 −2
Merged

Fix typo serialization key in AbstractCinematicEven (Issue #2449) #2668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99a1f16
Fix typo serialization key in AbstractCinematicEvent (#2449)
mondogo24 Mar 30, 2026
d1aef55
Refactor read(...) function in AbstractCinematicEvent.java
mondogo24 Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions jme3-core/src/main/java/com/jme3/cinematic/events/AbstractCinematicEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ public void write(JmeExporter ex) throws IOException {
OutputCapsule oc = ex.getCapsule(this);
oc.write(playState, "playState", PlayState.Stopped);
oc.write(speed, "speed", 1);
oc.write(initialDuration, "initalDuration", 10);
oc.write(initialDuration, "initialDuration", 10);
oc.write(loopMode, "loopMode", LoopMode.DontLoop);
}

Expand All @@ -306,7 +306,8 @@ public void read(JmeImporter im) throws IOException {
InputCapsule ic = im.getCapsule(this);
playState = ic.readEnum("playState", PlayState.class, PlayState.Stopped);
speed = ic.readFloat("speed", 1);
initialDuration = ic.readFloat("initalDuration", 10);
// Maintain backward compatibility for a typo in the serialization key "initalDuration".
initialDuration = ic.readFloat("initialDuration", ic.readFloat("initalDuration", 10));
loopMode = ic.readEnum("loopMode", LoopMode.class, LoopMode.DontLoop);
}

Expand Down
Loading