Safe (retrying, deadline-bounded) CV read/write#8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds safe, async CV programming methods that retry on a missing decoder acknowledgement and either return the value / succeed or throw a dedicated timeout exception, with a follow-up hardening pass from code review.
New API
IProgrammingControl.ReadCvAsync(cv, timeout)/WriteCvAsync(cv, value, timeout)— programming track.IZ21CommandStation.ReadPomCvAsync(loco, cv, timeout)/WritePomCvAsync(loco, cv, value, timeout)— POM (main line; POM write verifies via RailCom read-back).CvOperationTimeoutException,CvShortCircuitException.Z21Options.CvRetryDelay(default 50 ms) — backoff between NACK retries.Behaviour
LAN_X_CV_NACKuntil the caller's deadline; aborts immediately onLAN_X_CV_NACK_SC.Hardening (review fixes)
Task.WaitAsync), so a stalled transport cannot outlive the timeout.OperationCanceledExceptions propagate.Dispose()is idempotent and cancels in-flight operations (surfaced asObjectDisposedException); lock release tolerates disposal.Tests
17 unit tests for the safe CV flow (results, NACK retries, short circuit, timeouts, POM read-back, timeout validation, concurrency guard, dispose). Full solution green: 697 passed, hardware smoke tests skipped.