Fix: multi-jdk regression (due to AEsh migration)#2515
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
quintesse
force-pushed
the
fix_jdk_regression
branch
from
d3806df to
1e6ee37
Compare
|
Still a couple of failing tests, but that's because I changed them a bit because they were actually not testing the right way anymore for multi-jdk. But I won't have time to fix that until sunday at the earliest. |
|
@quintesse best you review and merge what makes sense. You know it better than me. I just offered the machine derived one in hope it could save some time. Merge and/or close what you find b best. If you want a second eye test before just let me know which pr :) |
|
@quintesse there are several fixes with #2516 that might be helpful to get in first? |
quintesse
force-pushed
the
fix_jdk_regression
branch
3 times, most recently
from
c6be05c to
e48b505
Compare
quintesse
force-pushed
the
fix_jdk_regression
branch
from
e48b505 to
151ac3d
Compare
…dows On macOS, temp directories resolve through /private/var (e.g. /var/folders/... -> /private/var/folders/...) causing jdkFolder.startsWith(jdksRoot) to return false when the jdkFolder path has been resolved via toRealPath() but jdksRoot has not. This caused LinkedJdk.linked() to fall through to ExternalJdkProvider, producing external-<hash> ids instead of the correct provider id. The fix adds an isUnderRoot() helper that falls back to comparing real (canonical) paths when the simple startsWith check fails. The resolved real root path is cached for performance. Fixes jbangdev/jbang#2515 test failures on macOS and Windows.
3 participants
No description provided.