Skip to content

feat: remove allow-same-origin for better security.#69

Merged
knightedcodemonkey merged 5 commits intonextfrom
bananas
Apr 11, 2026
Merged

feat: remove allow-same-origin for better security.#69
knightedcodemonkey merged 5 commits intonextfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

Copilot AI review requested due to automatic review settings April 11, 2026 19:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens preview iframe isolation by removing allow-same-origin and migrating the preview runtime bootstrapping from parent-driven contentDocument mutation to a srcdoc + postMessage protocol, while also adding telemetry hooks and caching to preserve diagnostics/performance.

Changes:

  • Replace same-origin iframe execution with a srcdoc bootstrap shell and a parent/iframe messaging protocol + reusable “bridge”.
  • Switch workspace virtual modules from Blob URLs + import-map wiring to cached data: module URLs with import specifier rewriting.
  • Add preview telemetry events and an E2E assertion that the iframe sandbox blocks parent storage access.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/modules/render-runtime.js Uses the new iframe bridge, adds preview telemetry, and adjusts auto-render debounce behavior.
src/modules/preview-runtime/virtual-workspace-modules.js Introduces caching + rewrites imports to produce data: module URLs instead of Blob URLs/import-map entries.
src/modules/preview-runtime/iframe-preview-protocol.js Adds a versioned message envelope and helpers for validating preview protocol messages.
src/modules/preview-runtime/iframe-preview-executor.js Replaces parent contentDocument bootstrapping with srcdoc shell, removes allow-same-origin, and implements the bridge + protocol handling.
src/modules/preview-background.js Removes direct iframe DOM access and forwards background-color changes via callback.
src/app.js Wires preview background color changes into the render runtime bridge update method.
playwright/rendering-modes.spec.ts Adds E2E test verifying sandbox isolation and inability to read parent localStorage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 7b742b5 into next Apr 11, 2026
5 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch April 11, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants