Skip to content

feat: remove allow-same-origin for better security. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knightedcodemonkey merged 5 commits into from
Apr 11, 2026
Merged

feat: remove allow-same-origin for better security. #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d893503
feat: remove allow-same-origin for better security.
knightedcodemonkey Apr 11, 2026
c1a4833
perf: better auto-render times.
knightedcodemonkey Apr 11, 2026
cedd79f
docs: delete preview benchmark docs.
knightedcodemonkey Apr 11, 2026
508677a
test: fix errors.
knightedcodemonkey Apr 11, 2026
f340b0f
test: fix failining.
knightedcodemonkey Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions playwright/rendering-modes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,38 @@
await expect(page.getByRole('status', { name: 'App status' })).not.toHaveText('Error')
})

test('preview iframe sandbox isolates parent origin access', async ({ page }) => {
await waitForInitialRender(page)

const iframe = page.locator('#preview-host iframe')
const sandbox = await iframe.getAttribute('sandbox')

expect(typeof sandbox).toBe('string')
expect(sandbox?.includes('allow-same-origin')).toBeFalsy()

await setComponentEditorSource(
page,
[
'const canReadParentStorage = (() => {',
' try {',
' return Boolean(window.parent.localStorage)',
' } catch {',
' return false',
' }',
'})()',
'',
'export const App = () => (',
" <button type='button'>",
" {canReadParentStorage ? 'parent-readable' : 'parent-blocked'}",
' </button>',
')',
].join('\n'),
)

await expect(page.getByRole('status', { name: 'App status' })).toHaveText('Rendered')
await expect(getPreviewFrame(page).getByRole('button')).toContainText('parent-blocked')
})

test('post-render runtime exceptions from iframe are reported in preview panel', async ({
page,
}) => {
Expand Down Expand Up @@ -606,7 +638,7 @@
await waitForInitialRender(page)
await ensurePanelToolsVisible(page, 'component')

await expect(page.getByRole('combobox', { name: 'Render mode' })).toHaveValue('react')

Check failure on line 641 in playwright/rendering-modes.spec.ts

View workflow job for this annotation

GitHub Actions / E2E (Playwright, chromium)

[chromium] › playwright/rendering-modes.spec.ts:630:1 › persists render mode across reload 

  1) [chromium] › playwright/rendering-modes.spec.ts:630:1 › persists render mode across reload ────
    Error: expect(locator).toHaveValue(expected) failed

    Locator:  getByRole('combobox', { name: 'Render mode' })
    Expected: "react"
    Received: "dom"
    Timeout:  90000ms

    Call log:
      - Expect "toHaveValue" with timeout 90000ms
      - waiting for getByRole('combobox', { name: 'Render mode' })
        93 × locator resolved to <select id="render-mode">…</select>
           - unexpected value "dom"


      639 |   await ensurePanelToolsVisible(page, 'component')
      640 |
    > 641 |   await expect(page.getByRole('combobox', { name: 'Render mode' })).toHaveValue('react')
          |                                                                     ^
      642 | })
      643 |
      644 | test('renders with less style mode', async ({ page }) => {
        at /home/runner/work/develop/develop/playwright/rendering-modes.spec.ts:641:69
})

test('renders with less style mode', async ({ page }) => {
Expand Down
8 changes: 8 additions & 0 deletions src/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,14 @@ const showAppToast = message => {
const previewBackground = createPreviewBackgroundController({
previewBgColorInput,
getPreviewHost: () => previewHost,
onBackgroundColorChange: color => {
if (
renderRuntime &&
typeof renderRuntime.updatePreviewBackgroundColor === 'function'
) {
renderRuntime.updatePreviewBackgroundColor(color)
}
},
getDefaultPreviewBackgroundColor: () => {
if (document.documentElement.dataset.theme === 'light') {
return '#ffffff'
Expand Down
14 changes: 5 additions & 9 deletions src/modules/preview-background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export const createPreviewBackgroundController = ({
previewBgColorInput,
getPreviewHost,
getDefaultPreviewBackgroundColor,
onBackgroundColorChange,
}) => {
let previewBackgroundColor = null
let previewBackgroundCustomized = false
Expand Down Expand Up @@ -66,26 +67,21 @@ export const createPreviewBackgroundController = ({
return
}

const iframe = previewHost.querySelector('iframe')
const iframeDocument = iframe?.contentDocument ?? null

if (typeof color === 'string' && color.length > 0) {
previewHost.style.backgroundColor = color
previewHost.style.setProperty('--preview-iframe-background-color', color)

if (iframeDocument) {
iframeDocument.documentElement.style.backgroundColor = color
iframeDocument.body.style.backgroundColor = color
if (typeof onBackgroundColorChange === 'function') {
onBackgroundColorChange(color)
}
return
}

previewHost.style.removeProperty('background-color')
previewHost.style.removeProperty('--preview-iframe-background-color')

if (iframeDocument) {
iframeDocument.documentElement.style.removeProperty('background-color')
iframeDocument.body.style.removeProperty('background-color')
if (typeof onBackgroundColorChange === 'function') {
onBackgroundColorChange('')
}
}

Expand Down
Loading
Loading