fix: sync SliceDisplayName on every reconcile in updateSliceConfig#494
Open
mdryaan wants to merge 1 commit into
Open
fix: sync SliceDisplayName on every reconcile in updateSliceConfig#494mdryaan wants to merge 1 commit into
mdryaan wants to merge 1 commit into
Conversation
Signed-off-by: Md Raiyan <alikhurshid842001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
updateSliceConfiginpkg/hub/controllers/slice_controller.goonly setSliceDisplayNameinside theif meshSlice.Status.SliceConfig == nilblock populated once at first creation and never updated again. If the display name changed in the hubWorkerSliceConfig, the worker cluster'sSlice.Status.SliceConfig.SliceDisplayNamewould hold the stale value indefinitely with no way to reconcile it short of deleting and recreating the slice.All other runtime-mutable fields (QoS profile, namespace isolation, gateway service type, external gateway config, etc.) are already synced unconditionally on every reconcile.
SliceDisplayNamewas simply missed.SliceTypeis intentionally left inside the nil guard — it is immutable after slice creation and that behaviour is unchanged.Fix adds one unconditional assignment after the nil guard, mirroring exactly how
SliceGatewayServiceTypeis handled in the same function.Fixes #493
How Has This Been Tested?
Added
TestUpdateSliceConfigDisplayNameUpdatedOnSubsequentReconciletopkg/hub/controllers/slice_controller_unit_test.go. The test constructs aSlicewithSliceConfigalready non-nil (simulating a subsequent reconcile after initial creation) and a staleSliceDisplayName, callsupdateSliceConfigwith an updated hub config, and asserts the field is overwritten with the new value.TestUpdateSliceConfigDisplayNameUpdatedOnSubsequentReconcile— passesmake fmt— no formatting changesmake vet— no issuesmake build— builds cleanlymake test— all suites pass; pre-existing spoke timeout failures confirmed identical on masterChecklist:
go fmtDoes this PR introduce a breaking change?