Skip to content

fix: sync SliceDisplayName on every reconcile in updateSliceConfig #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdryaan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: sync SliceDisplayName on every reconcile in updateSliceConfig #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/hub/controllers/slice_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,8 @@ func (r *SliceReconciler) updateSliceConfig(ctx context.Context, meshSlice *kube
SliceType: spokeSlice.Spec.SliceType,
}
}
meshSlice.Status.SliceConfig.SliceDisplayName = spokeSlice.Spec.SliceName

if meshSlice.Status.SliceConfig.SliceSubnet == "" {
meshSlice.Status.SliceConfig.SliceSubnet = spokeSlice.Spec.SliceSubnet
}
Expand Down
44 changes: 44 additions & 0 deletions pkg/hub/controllers/slice_controller_unit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,50 @@ func TestUpdateSliceConfigByModyfingSubnetOfControllerSlice(t *testing.T) {
t.Error("Expected error:", controllerSlice.Spec.SliceSubnet, " but got ", workerslice.Status.SliceConfig.SliceSubnet)
}
}
func TestUpdateSliceConfigDisplayNameUpdatedOnSubsequentReconcile(t *testing.T) {
client := NewClient()
reconciler := &SliceReconciler{
Client: client,
MeshClient: client,
Log: ctrl.Log.WithName("controller").WithName("controllers").WithName("SliceConfig"),
}
ctx := context.WithValue(context.Background(), types.NamespacedName{Name: "test-slice", Namespace: "kubeslice-system"}, controllerSlice)

client.StatusMock.On("Update",
mock.IsType(ctx),
mock.IsType(&kubeslicev1beta1.Slice{}),
mock.IsType([]k8sclient.SubResourceUpdateOption(nil)),
).Return(nil)

slice := &kubeslicev1beta1.Slice{
ObjectMeta: metav1.ObjectMeta{
Name: "test-slice",
Namespace: "kubeslice-system",
},
Status: kubeslicev1beta1.SliceStatus{
SliceConfig: &kubeslicev1beta1.SliceConfig{
SliceDisplayName: "old-display-name",
},
},
}
hubSlice := &workerv1alpha1.WorkerSliceConfig{
Spec: workerv1alpha1.WorkerSliceConfigSpec{
SliceName: "new-display-name",
SliceGatewayProvider: workerv1alpha1.WorkerSliceGatewayProvider{
SliceGatewayServiceType: "NodePort",
},
},
}
err := reconciler.updateSliceConfig(ctx, slice, hubSlice)
if err != nil {
t.Error("Expected no error but got:", err)
}
if slice.Status.SliceConfig.SliceDisplayName != "new-display-name" {
t.Errorf("Expected SliceDisplayName to be updated to %q but got %q",
"new-display-name", slice.Status.SliceConfig.SliceDisplayName)
}
}

func TestDeleteSliceResourceOnWorker(t *testing.T) {
expected := struct {
ctx context.Context
Expand Down