Skip to content

add a new setting with AboveRare so players can adjust what score they want to put ex orb if the item is Rare.(also change rendering into checking item rarity instead of prefix count) also fix prefix/suffix count num#4

Open
takaqiao wants to merge 2 commits into
kvcrek:masterfrom
takaqiao:master

Conversation

@takaqiao
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Owner

@kvcrek kvcrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are ok, better way of finding the number of prefix/suffix count but I don't see any point in 'MinimumCraftHighlightScoreAboveRare' as the plugin already shows which maps are already worth crafting (no matter if it's magic or rare item)

@takaqiao
Copy link
Copy Markdown
Author

changes are ok, better way of finding the number of prefix/suffix count but I don't see any point in 'MinimumCraftHighlightScoreAboveRare' as the plugin already shows which maps are already worth crafting (no matter if it's magic or rare item)

from what I see its like worth using ex orb or not.So if the item become rare but still not above specific score we maybe should just stop investing the map?maybe adding a option to this will be better.too much coding today I will change it later :p

@kvcrek
Copy link
Copy Markdown
Owner

kvcrek commented Jan 20, 2025

If you want to use exalt on rare map its up to you, this plugin was meant to help with managing large stash with lots of maps to find good ones and ones with potential to exalt. I was using exalt on every single highlighted map that met my criteria.

If you wonder to use ex orb or not, try to adjust your settings to highlight maps that you would 100% exalt then ;)

@takaqiao
Copy link
Copy Markdown
Author

If you want to use exalt on rare map its up to you, this plugin was meant to help with managing large stash with lots of maps to find good ones and ones with potential to exalt. I was using exalt on every single highlighted map that met my criteria.

If you wonder to use ex orb or not, try to adjust your settings to highlight maps that you would 100% exalt then ;)

I guess u r right everyone using regal or alch on every map so its a shortcut.just reagal or alch every maps then set a higher craft score the problem will be solved. I will edit code later

@takaqiao
Copy link
Copy Markdown
Author

takaqiao commented Jan 21, 2025

Just got a really weird rendering issue after core update.maps in several normal stash will render info into inventory instead of stash item itself.if I move map into other normal stash it will render normally.
for me its like last 3 stash will cause the problem.dont know how to reproduce it.lol
also caused on other tablet plugin.but it fixed itself... so weird
anyway I changed the code it works perfect right now

@takaqiao
Copy link
Copy Markdown
Author

still need changes or sth? I already revert the AboveRave part as u said.

@kvcrek
Copy link
Copy Markdown
Owner

kvcrek commented Jan 25, 2025

What I don't like is that this PR has too many changes and I like only the one that changes the way prefixes are counted (also a fix to other languages).

Currently I can't play poe2, but hopefully I'll address this issue soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants