Conversation
hsklogix
requested changes
Aug 5, 2022
| """ | ||
| def __init__(self, name, staff_id): | ||
| Person.__init__(self, name) | ||
| #Person.__init__(self, name) |
Collaborator
There was a problem hiding this comment.
Please remove the commented code
|
|
||
| time = '11:23 PM' | ||
|
|
||
| def getparentdata(self): |
Collaborator
There was a problem hiding this comment.
Let's use the snake case while defining any function name.
|
|
||
| date = '12/08/2018' | ||
|
|
||
| def getparentdata(self): |
| def test_multiple_inheritance(): | ||
| """Multiple Inheritance""" | ||
|
|
||
| class Parent: |
Collaborator
There was a problem hiding this comment.
In this example you'll have to test multiple inheritance, while you are testing only simple inheritance.
| # Each car has separate features list | ||
| assert car1.features == ["Back Camera"] | ||
|
|
||
|
No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Practiced python classes concepts.