fix(release): inline footnote — HF card renderer doesn't support footnotes#95
Merged
Conversation
…otnotes] Convert the [^macro] footnote to an inline parenthetical so the macroeconomic context renders correctly on HuggingFace. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shaypal5
added
type: bugfix
|
pr-agent-context report: No unresolved review comments, failing checks, or actionable patch coverage gaps were found on PR #95 in repository https://github.com/leadforge-dev/leadforge. Treat this PR as all clear unless new signals appear.Run metadata: |
There was a problem hiding this comment.
Pull request overview
Updates the release dataset README(s) to avoid Markdown footnote syntax ([^...]) because Hugging Face’s dataset card renderer uses CommonMark and renders footnotes as raw text.
Changes:
- Replaces the
[^macro]footnote marker + definition with an inline parenthetical note inrelease/README.md. - Applies the same footnote-to-inline conversion in
release/huggingface/README.md(HF dataset card).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| release/README.md | Removes CommonMark-incompatible footnote syntax by inlining the macro note. |
| release/huggingface/README.md | Mirrors the same inline-footnote change for the Hugging Face dataset card README. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
14
to
+16
| Mid-market SaaS vendors entered 2024–2026 with growth slowing and | ||
| customer-acquisition costs rising[^macro], so predicting *which* leads | ||
| convert within a fixed window has moved from a marketing nicety to a | ||
| survival skill. This dataset teaches that skill on a relational | ||
| substrate, with the realistic confusions (snapshot-window discipline, | ||
| leakage traps, channel signal weaker than vendor blogs imply) that | ||
| students will hit when they finally get hands on real CRM data. | ||
|
|
||
| [^macro]: Macroeconomic framing summarised in | ||
| [`docs/external_review/summaries/gemini_v2_summary.md`](../docs/external_review/summaries/gemini_v2_summary.md) | ||
| (median public-SaaS growth 30%→25% from 2023 to 2025; New CAC Ratio | ||
| rose materially in 2024). | ||
| customer-acquisition costs rising (median public-SaaS growth 30%→25% | ||
| from 2023 to 2025; New CAC Ratio rose materially in 2024), so |
Comment on lines
59
to
+61
| Mid-market SaaS vendors entered 2024–2026 with growth slowing and | ||
| customer-acquisition costs rising[^macro], so predicting *which* leads | ||
| convert within a fixed window has moved from a marketing nicety to a | ||
| survival skill. This dataset teaches that skill on a relational | ||
| substrate, with the realistic confusions (snapshot-window discipline, | ||
| leakage traps, channel signal weaker than vendor blogs imply) that | ||
| students will hit when they finally get hands on real CRM data. | ||
|
|
||
| [^macro]: Macroeconomic framing summarised in | ||
| [`docs/external_review/summaries/gemini_v2_summary.md`](https://github.com/leadforge-dev/leadforge/blob/main/docs/external_review/summaries/gemini_v2_summary.md) | ||
| (median public-SaaS growth 30%→25% from 2023 to 2025; New CAC Ratio | ||
| rose materially in 2024). | ||
| customer-acquisition costs rising (median public-SaaS growth 30%→25% | ||
| from 2023 to 2025; New CAC Ratio rose materially in 2024), so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HuggingFace's dataset card renderer uses standard CommonMark, which doesn't support
[^footnote]syntax. The marker and definition were rendering as raw text. Converted to an inline parenthetical.🤖 Generated with Claude Code