fix: use direct construction for JustifiedSlots#513
Closed
tcoratger wants to merge 1 commit intoleanEthereum:mainfrom
Closed
fix: use direct construction for JustifiedSlots#513tcoratger wants to merge 1 commit intoleanEthereum:mainfrom
tcoratger wants to merge 1 commit intoleanEthereum:mainfrom
Conversation
Replace `JustifiedSlots(data=[]).model_copy(update={"data": [...]})` with
`JustifiedSlots(data=[...])` across all 8 occurrences in test_justification.py.
The model_copy pattern bypassed Pydantic validation, leaving a mutable list
instead of the expected immutable tuple. Direct construction is simpler and
produces correctly validated data.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Closing: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JustifiedSlots(data=[]).model_copy(update={"data": [...]})withJustifiedSlots(data=[...])across 8 occurrences intest_justification.pymodel_copypattern bypassed Pydantic validation, leaving a mutablelistinstead of the expected immutabletupleTest plan
uvx tox -e all-checks— all green🤖 Generated with Claude Code