Skip to content

fix: use direct construction for JustifiedSlots #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tcoratger wants to merge 1 commit into from
Closed

fix: use direct construction for JustifiedSlots #513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 15 additions & 21 deletions tests/consensus/devnet/state_transition/test_justification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ def test_repeated_validator_does_not_double_count_within_same_block(
slot=Slot(2),
latest_justified_slot=Slot(0),
latest_finalized_slot=Slot(0),
justified_slots=JustifiedSlots(data=[]).model_copy(update={"data": [Boolean(False)]}),
justified_slots=JustifiedSlots(data=[Boolean(False)]),
justifications_validators=JustificationValidators(
data=[
Boolean(True),
Expand Down Expand Up @@ -518,9 +518,7 @@ def test_pending_justification_survives_finalization_rebase(
slot=Slot(5),
latest_justified_slot=Slot(2),
latest_finalized_slot=Slot(1),
justified_slots=JustifiedSlots(data=[]).model_copy(
update={"data": [Boolean(True), Boolean(False), Boolean(False)]}
),
justified_slots=JustifiedSlots(data=[Boolean(True), Boolean(False), Boolean(False)]),
justifications_validators=JustificationValidators(
data=[
Boolean(True),
Expand Down Expand Up @@ -915,7 +913,7 @@ def test_split_supermajority_aggregations_in_same_block_justify(
slot=Slot(2),
latest_justified_slot=Slot(1),
latest_finalized_slot=Slot(0),
justified_slots=JustifiedSlots(data=[]).model_copy(update={"data": [Boolean(True)]}),
justified_slots=JustifiedSlots(data=[Boolean(True)]),
justifications_roots=JustificationRoots(data=[]),
justifications_validators=JustificationValidators(data=[]),
),
Expand Down Expand Up @@ -967,7 +965,7 @@ def test_odd_validator_threshold_boundary_justifies(
slot=Slot(2),
latest_justified_slot=Slot(1),
latest_finalized_slot=Slot(0),
justified_slots=JustifiedSlots(data=[]).model_copy(update={"data": [Boolean(True)]}),
justified_slots=JustifiedSlots(data=[Boolean(True)]),
justifications_roots=JustificationRoots(data=[]),
justifications_validators=JustificationValidators(data=[]),
),
Expand Down Expand Up @@ -1018,7 +1016,7 @@ def test_odd_validator_threshold_boundary_does_not_justify(
slot=Slot(2),
latest_justified_slot=Slot(0),
latest_finalized_slot=Slot(0),
justified_slots=JustifiedSlots(data=[]).model_copy(update={"data": [Boolean(False)]}),
justified_slots=JustifiedSlots(data=[Boolean(False)]),
justifications_validators=JustificationValidators(
data=[
Boolean(True),
Expand Down Expand Up @@ -1160,9 +1158,7 @@ def test_justification_clears_only_the_resolved_target_votes(
slot=Slot(4),
latest_justified_slot=Slot(1),
latest_finalized_slot=Slot(0),
justified_slots=JustifiedSlots(data=[]).model_copy(
update={"data": [Boolean(True), Boolean(False), Boolean(False)]}
),
justified_slots=JustifiedSlots(data=[Boolean(True), Boolean(False), Boolean(False)]),
justifications_validators=JustificationValidators(
data=[
Boolean(True),
Expand Down Expand Up @@ -1278,7 +1274,7 @@ def test_finalization_prunes_stale_pending_votes_and_rebases_window(
slot=Slot(6),
latest_justified_slot=Slot(5),
latest_finalized_slot=Slot(4),
justified_slots=JustifiedSlots(data=[]).model_copy(update={"data": [Boolean(True)]}),
justified_slots=JustifiedSlots(data=[Boolean(True)]),
justifications_roots=JustificationRoots(data=[]),
justifications_validators=JustificationValidators(data=[]),
),
Expand Down Expand Up @@ -1384,16 +1380,14 @@ def test_target_at_or_before_source_is_ignored(
slot=Slot(6),
latest_justified_slot=Slot(4),
latest_finalized_slot=Slot(0),
justified_slots=JustifiedSlots(data=[]).model_copy(
update={
"data": [
Boolean(True),
Boolean(False),
Boolean(False),
Boolean(True),
Boolean(False),
]
}
justified_slots=JustifiedSlots(
data=[
Boolean(True),
Boolean(False),
Boolean(False),
Boolean(True),
Boolean(False),
]
),
justifications_validators=JustificationValidators(
data=[
Expand Down
Loading