Repository navigation
fix(context): reuse digest owner for capture recovery - #7300
Merged
Merged
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
Two digest architecture checks fail on main
af68b0ff180ca8309b5d63d7ee326c77848521bb: capture recovery repeats the canonical bare SHA-256 grammar, and a schema test incorrectly assumes every digest field is bare. Capture IO now borrows the existing canonical pattern. The schema regression checks each field's actual contract: bare request IDs and enveloped revisions/references.main. Related to perf(quota): compact shared packets and preserve replan context #7285; this repair is independently reproducible on main.Author Declaration
quota_capture.pyimports the generatedBARE_SHA256_PATTERN; consumer manifest pins it_read_capture,read_context_capturerequest_id,expected_source_revision,delivery_refScope And Continuation
Complete within this scope. The adjacent refactor replaces two repeated patterns with their existing owner; activation, capture hashing, error order and authority behavior are preserved. The packet optimization and host/outcome qualification in #7285 remain separate and open. No additional follow-up task is needed for this repair.
Validation
0ec2d0e1f(same file contents as the focused validation).git diff --check; staged RFC bilingual check (no RFC changed); diff-scoped vocabulary advisory0.163.0-alpha.11.1; deterministic local loopback and isolated SQLite fixtures. All 8 pass without skips (181.86 s). The earlier 50 native skips remain historical; the other native cases were not rerunquota-scheduler-registry-route-smoke.pyfails withcanonical_authority_requiredon both the exact main baseline and this head; this remains a merge holdtest_codex_attached_conversation.py; its source bytes and all five findings match the exact main baseline. The build job fails thegoal-activitybrowser assertion; no paired baseline browser reproduction is claimed. The stage2c wrapper rejects a skipped prerequisite. None of these observations waives the merge hold.Frontend / Visual Evidence
Type of Change
LoopX Area
Shared-authority RFC fixture impact
N/A: no store, promotion, runtime routing or compatibility-projection change.
Boundary Checklist