Repository navigation
test(workspace): reach accepted report checks through explicit navigation - #7350
Conversation
…ports Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · max
动机
维护者和依赖浏览器回归发现已验收报告读取问题的贡献者。
旧测试在未进入的视图等待可选目标声明而超时;本头明确进入概览,确认实际视图与选中导航,再进入成果检查原报告边界。
同一真实打包前端及合成 API fixture 下,完整旧场景在原30秒等待复现失败,本头保留的报告断言全部通过。
不改变产品界面、报告 owner、fixture、超时或权限;不声称安装态、真实报告后端或整个浏览器分片通过。
本次价值是恢复已有验收的辨别能力:原测试尚未到报告读取就停下,无法检查读取顺序、失效清除及零模型调用。一次测试通过并不证明整个产品或 CI 已恢复。
改动思路
重用既有 Goal 导航和原 managed-goal-results 场景,以实际视图状态代替无关可选字段的就绪假设;没有新增 helper、fixture 或重复 smoke。
本 PR 交付现有验收场景的可达性修复;API 返回仍为合成路由,实际业务后端、安装态和整页视觉资格分别保留。
不能简单删除等待后继续在默认对话页检查“没有报告”,那会让概览边界断言空过。新代码通过原导航点击概览、等待实际 .goal-overview,并检查概览按钮 aria-current=page,才验证概览不读取正文。随后同一个导航定位进入成果。原数据、断言、30000ms超时、渲染器与产品入口均未改。
具体改动
先读固定版本 design.md,spec_revision b95223532af1cc3cc6bd9558f96750c79f581e1b。outputs in Files、Opening or switching a view only reads、Goal-wide statistics in Overview 分别约束成果位置、阅读不启动模型及视图分工。本头仅让现有验收按该真实导航执行,没有新增产品语义。另检查原 local-delegation accepted-read 合同和实际读取者;5940/5944 的经验用于核对普通阅读及失败恢复,没有把历史评价当本头结论。
managedGoalResultsScenario.run:37:删除可选目标声明的就绪等待,增加原导航的概览点击、实际视图等待和选中状态断言;复用 locator 进入成果。整PR仅一个既有文件 +5/-2。- 原目录/概览零正文读取、inventory→body顺序、首次恰好一次正文读取、表格与无script/img、390px容器宽度、409清除旧表格、malformed inventory错误及原成果仍可用、
turnRequests=0全部保留。 - 未改
GoalOverview明确只在digest.objective存在时渲染目标声明;普通 fixture 没有此可选值。既有goal-showcase专门提供并检查该声明。本轮又实际打开原 showcase fixture,独立读取到其完整声明,未用新增字段把旧测试强行变绿。
对主干的风险
最强反例是只换等待便漏掉实际视图或删除有效产品覆盖。我用不可变 base b95223532af1cc3cc6bd9558f96750c79f581e1b 和本头 25909b1ef1aaeb37659835892b0fafa1bd0f0686 的完整原场景函数,在同一真实打包前端、ChatHTTPServer与Chromium上执行;只把两个相对import链接到相同原fixture/场景上下文,未改断言。前端、Python后端和设计文档的Git tree/object身份逐项相同,产品没有悄悄切换版本。
完整旧场景在原 goal-declared-objective 等待处 30000ms timeout;该失败被原样保留。本头全部原报告断言通过(1406ms只是单次测试时间,不是性能收益)。额外的已提供目标声明场景仍显示原完整文字。测试使用实际已构建、与源码匹配的打包资源;业务 API 返回是合成路由,不冒称真实已验收文件 owner 端到端已过。
已读取桌面1512×982和窄屏390×844捕获:报告与表格实际出现,窄屏容器断言通过。未改渲染器中可滚动表格的局部列头裁切仍可见;该容器断言不等于整页视觉或所有表格文字的完整资格,也不是本次导航修复引入的变化。本PR没有产品UI改动,无需新设计/首屏变更提案。
既有覆盖检索区分了本场景、report-download 的实际下载字节、team-plan 的依赖证据读取,以及 goal-showcase 的目标声明。当前同作者7350–7354队列作有界元数据扫描,各自是不同既有问题/owner;没有新增重复smoke或成立的重复低值贡献证据,不触发贡献限制建议。
语义与 CI 对齐
配置指定 build:chat 的类型检查、构建及源码绑定验证通过;原生standard premerge 4直接+3选中 检查通过,零失败/人工hold,精确 CQR cqr_cbd5baaa992348547fd4 PASS且verify有效。没有改预算、删原报告断言、缩小语义扫描或改产品实现来掩盖失败。判定依据为本地完整场景和旧版反例,没有等待CI;不推断完整浏览器catalog、安装态或实时后端通过。
我的整体评价
对 25909b1ef1aaeb37659835892b0fafa1bd0f0686:APPROVE,当前范围的验收可达性问题已修复,未发现新阻断。long_horizon为improved,指验收反馈不再被无关就绪假设挡住;user_experience为preserved,产品代码完全未改,不据此宣称长期收益。
重用既有 Goal 导航和原 managed-goal-results 场景,以实际视图状态代替无关可选字段的就绪假设;没有新增 helper、fixture 或重复 smoke。 本 PR 交付现有验收场景的可达性修复;API 返回仍为合成路由,实际业务后端、安装态和整页视觉资格分别保留。
有界整理已落实为复用一个导航定位器,不需新helper、通用等待框架或人为后继任务。保留旧超时、合成API边界、窄屏视觉限制和更大测试资格。批准、当前有效阻断、质量资格与维护者合并权限分别处理;未合并、安装或撤销他人意见。
English verdict: APPROVE — 25909b1ef1aaeb37659835892b0fafa1bd0f0686 repairs the existing accepted-report scenario through explicit shipped navigation and actual Overview selection. The full immutable base scenario reproduces its original30s optional-objective timeout; the head retains and passes all report-order, stale/malformed, narrow-container and zero-model assertions. Supplied-objective coverage remains visible in its owning fixture. Product trees are unchanged; packaged build, native4+3 checks and exact CQR pass. Synthetic API routes and container fit do not qualify the installed backend, full browser catalog or whole-page visual quality.
|
Correction to the batch-attribution sentence in review5647027551 for 更正批次归属:本评审把7350–7354统称“同作者”不准确。BigDataDZ对应7350、7351;7352–7354属于songoow,不计入该贡献者批次。正确范围下未发现重复smoke或成立的重复低值贡献证据;不改变本头完整测试修复的批准结论及已披露边界。 |
Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
Problem and result
The required dashboard browser lane on main times out before accepted-report checks: managed-goal-results waits for a declared objective in an unvisited view, and the ordinary fixture does not supply that optional declaration.
Explicitly enter Overview through the shipped Goal navigation and verify that the actual Overview is visible and selected, then enter Files. Preserve the report boundary assertions: no body read in the directory/Overview, inventory before the selected body, exactly one initial read, safe rendering, phone fit, stale content clearing, malformed inventory recovery and zero model calls.
Author Declaration
Written by: model_agent (OpenAI Codex), under the author's direction. Basis: current-main dashboard CI failure and the original-conversation default; docs/development/design.md task-first navigation and existing managed-report read contract. Intended base: main, integrated parent e905d34. Tested head: 6522db6.
Validation
Run state: finished. Inputs: synthetic API fixtures and freshly built, source-verified packaged frontend. Native Windows, Node 24.20.0 / Playwright Chromium headless shell 151.
Scope and continuation
One existing browser scenario, no new helper or framework. Reuse the actual Goal navigation and retire a stale optional-field readiness assumption. Frontend/Lark/CLI product entrypoints are unchanged. Current-head review and CI remain pending. Shared CI failures elsewhere remain separate; no models, benchmarks, active Goal changes or self-merge.
Current integration: inherited the merged linked-source lint and current-session model-menu repairs from main; freshly rebuilt and source-verified packaged assets pass the complete scenario again. The previous 25909b1 review remains historical and is not approval of this new integration head. No extra product changes or duplicated fixes.