Skip to content

test(research): unblock the required linked-source lint check - #7351

Merged
huangruiteng merged 1 commit into
mainfrom
codex/linked-source-static-unblock-20261026
Oct 26, 2026
Merged

huangruiteng merged 1 commit into
mainfrom
codex/linked-source-static-unblock-20261026

Conversation

@BigDataDZ

Copy link
Copy Markdown
Contributor

Problem and result

The required kernel static lane on main and current contribution branches stops at F401 in tests/presentation/test_linked_goal_sources.py. Remove the unused explore_history_rows import left after the source-reading refactor so the existing lint step can reach the remaining checks. No test assertion or runtime behavior changes.

Validation

  • The unchanged main file reproduces the precise F401; the symbol has no use elsewhere in this module.
  • The exact CI lint surface passes: python -m ruff check tests loopx/canary loopx/control_plane loopx/domain_packs loopx/presentation.
  • Diff hygiene, bilingual check, DCO and public-boundary scan pass. Single test-import deletion; no UI, protocol, permission or persisted-state change.
  • The optional native Windows module replay is unqualified: default temporary paths hit the existing long-path fixture setup failure; a shorter disposable root did not finish and the owned test/runtime processes were terminated. No unit-suite pass is claimed.
  • An exploratory wider Ruff scan also reports errors outside this CI surface; this change does not claim to clear all repository diagnostics.

Written by model_agent (OpenAI Codex), under the author's direction. Tested head: 1e3cb90; target/merge base main b952235. Existing source/test owner retained; further refactoring is unnecessary for an unused import. Current-head CI and independent review remain pending. No active Goal, model, benchmark, system upgrade or self-merge.

Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · max

动机

维护者和等待必需静态检查通过后继续验证的贡献者。

主干测试模块留下一个未使用的导入,必需 lint 步骤在进入后续资格验证前失败;本头只删除该无用名称。

不可变基线在原位置复现唯一 F401;本头运行工作流声明的完整 lint 范围通过,原模块13项测试全部通过。

不改变运行时、测试断言、工作流或合并要求;没有证明完整 CI、Windows 或安装态已经通过。

这里的收益是恢复已有验证入口:未使用名称使必需静态步骤提前退出,后续验证无法提供有效反馈;不是新增测试数量或运行时功能。

改动思路

现有模块和 lint 步骤已经拥有该检查,只需删去无引用的导入别名,无需新 smoke、helper、抑制规则或范围豁免。

这是必需静态检查可达性的完整单点修复;更大测试矩阵的独立资格仍由其原入口负责。

我先读取既有检查与 smoke 保留规范,再检查不可变工作流和代码。工作流 kernel-static-checks 的 Lint test suite 使用折叠 YAML 声明完整 Ruff 范围;此次没有删路径、改规则、加 noqa 或给失败设置豁免。既有测试模块仍负责相同的来源隔离与读回行为。

具体改动

规格依据:required merge check,spec_revision b95223532af1cc3cc6bd9558f96750c79f581e1b;保留独有语义覆盖参照同版本 docs/development/good-smokes.md。required_static_lane 与 preserve_unique_coverage 两项均 implemented:修复被实际复现的静态失败,保持原检查和全部测试断言。

test_linked_goal_sources.py:21–24 仅在原 result_log 导入中去掉 explore_history_rows,单文件 +1/-1。我扫描完整模块的名称引用,确认没有使用它;从基线 AST 删除这一导入别名后,整个模块 AST 与本头相同。所有函数、断言及其他导入都保留。loopx、apps、packages 的 Git tree 逐一相同,运行时、UI 和工作流均未变化。

完整49项开放队列中,我对实际作者 BigDataDZ 的六项标题及路径作有界扫描;#7350 是另一处既有导航验收修复,#7351 是必需 lint 缺陷,其他项涉及不同 provider/runtime owner。没有新增重复 smoke 或成立的重复低值提交证据,不提出贡献限制。5940/5944 经验用于核对实际可验证结果;没有把历史结论继承给本头,也没有要求这个内部维护修复交付无关产品功能。

对主干的风险

主要反例是通过改断言或弱化 lint 获得表面绿色。我用同一 Ruff 配置和原文件名读取不可变 base 内容,复现唯一 F401,位置为23:5;本头执行工作流原有完整范围 tests loopx/canary loopx/control_plane loopx/domain_packs loopx/presentation,全部通过。13项既有模块测试实际运行通过,零跳过;完整 AST 和产品树比较独立排除了变更断言或运行时来掩盖失败。

原生 standard premerge 的五个直接检查通过,当前测试路径没有额外选中 canary。首次总门保留了复用工作树上一精确头的 quality_stale_receipt;没有把这个 hold 当作通过。随后按当前 base/head 重新执行质量审查、写入 cqr_24de980c1a281536d273,物理收据全部字段读回相等且 verify 有效,再运行总门通过。未修改校验器、冻结条件或失败记录。

作者披露的原生 Windows 试验和更广仓库诊断未在本机重跑,保持未验收;本结论也不据此宣称完整CI已绿。按当前配置不查询、轮询或等待CI。未改产品页面,不涉及首屏设计资格。没有新增语义词汇、权限或持久化合同。

我的整体评价

对 1e3cb90cba81930d95e23a39703eb3e451981cf8:APPROVE。规格内的静态失败已修复,全部原测试语义保留,未发现新增阻断。long_horizon为improved,指既有反馈入口可继续;user_experience为preserved,产品树完全未变,不宣称求解效果、性能或真实使用收益。

现有模块和 lint 步骤已经拥有该检查,只需删去无引用的导入别名,无需新 smoke、helper、抑制规则或范围豁免。 这是必需静态检查可达性的完整单点修复;更大测试矩阵的独立资格仍由其原入口负责。

有界整理就是删除无用别名,不需再引入框架或人为后继任务。保留 Windows、完整测试矩阵和安装态资格边界;批准不授予合并权限,本次未合并或安装。

English verdict: APPROVE — 1e3cb90cba81930d95e23a39703eb3e451981cf8 removes one unused import alias causing the required lint lane's reproducible F401. The full declared lint surface and all13 existing linked-source tests pass; complete module AST except that alias and all product trees are unchanged. Five native direct checks and the final exact-scope quality gate pass. The initial stale-receipt hold is preserved; full CI, Windows and installed behavior remain separately unqualified.

@huangruiteng
huangruiteng merged commit 82bb83f into main Oct 26, 2026
22 of 37 checks passed
@huangruiteng
huangruiteng deleted the codex/linked-source-static-unblock-20261026 branch October 26, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants