docs(skills): fix small typos in skill references#412
Closed
AllDmeat wants to merge 1 commit into
Closed
Conversation
Author
|
@microsoft-github-policy-service agree company="Dodo Engineering" |
- spec-driven-testing.md: `Singing in and out` → `Signing in and out` - storage-state.md: bump example cookie `expires` from 1735689600 (Jan 1, 2025) to 1893456000 (Jan 1, 2030) so the example doesn't read as already-expired - video-recording.md: `pulling appropriate pauses` → `inserting appropriate pauses`
AllDmeat
force-pushed
the
fix/typos-in-skill-references
branch
from
b1e7f02 to
f626401
Compare
Contributor
|
@AllDmeat Thank you for the PR! The source of truth for this skill lives in playwright repository, and is periodically rolled into here. Could you please open a PR against playwright instead? Thank you! |
Author
|
Thanks for the pointer @dgozman! Reopened against playwright: microsoft/playwright#40942 — closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a few small issues in
skills/playwright-cli/references/*while vendoring the skills into another project and getting them reviewed:spec-driven-testing.md— example test group name was'Singing in and out', changed to'Signing in and out'.storage-state.md— both theexpiresexample in the storage-state JSON (line 41) and the--expiresexample forcookie-set(line 95) used Unix timestamp1735689600, which is Jan 1 2025 — already in the past, making the cookie examples read as expired. Bumped both to1893456000(Jan 1 2030).video-recording.md— "pulling appropriate pauses between the actions" → "inserting appropriate pauses".No behavior changes — docs only.