docs(cli-client/skill): fix small typos in skill references#40942
Open
AllDmeat wants to merge 1 commit into
Open
docs(cli-client/skill): fix small typos in skill references#40942AllDmeat wants to merge 1 commit into
AllDmeat wants to merge 1 commit into
Conversation
- spec-driven-testing.md: `Singing in and out` → `Signing in and out` - storage-state.md: bump example cookie `expires` from 1735689600 (Jan 1, 2025) to 1893456000 (Jan 1, 2030) so the example doesn't read as already-expired - video-recording.md: `pulling appropriate pauses` → `inserting appropriate pauses` Same fixes were originally opened as microsoft/playwright-cli#412; @dgozman pointed out this is the source of truth, redoing it here.
Contributor
Test results for "MCP"2 failed 7179 passed, 1113 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally opened against microsoft/playwright-cli#412; @dgozman pointed out the source of truth lives here, redoing the PR against this repo.
Small fixes in
packages/playwright-core/src/tools/cli-client/skill/references/:spec-driven-testing.md— example test group name was'Singing in and out', changed to'Signing in and out'.storage-state.md— both theexpiresexample in the storage-state JSON (line 41) and the--expiresexample forcookie-set(line 95) used Unix timestamp1735689600, which is Jan 1 2025 — already in the past, making the cookie examples read as expired. Bumped both to1893456000(Jan 1 2030).video-recording.md— "pulling appropriate pauses between the actions" → "inserting appropriate pauses".No behavior changes — docs only.