fix(test-runner): run teardown projects when maxFailures is reached#41737
Open
yury-s wants to merge 1 commit into
Open
fix(test-runner): run teardown projects when maxFailures is reached#41737yury-s wants to merge 1 commit into
yury-s wants to merge 1 commit into
Conversation
When a run is interrupted by maxFailures, teardown projects were skipped, so their cleanup (e.g. clearing a database) never ran. Exempt teardown project test groups from the maxFailures interruption via a TestGroup.ignoreMaxFailures flag so they still run. Fixes: microsoft#41713
Contributor
Test results for "MCP"1 failed 7759 passed, 1249 skipped Merge workflow run. |
Contributor
Test results for "tests 1"8 flaky49528 passed, 1161 skipped Merge workflow run. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--max-failures, so their cleanup (e.g. clearing a database) never ran.TestGroup.ignoreMaxFailuresflag), so they still run while everything else stops.Fixes #41713