fix --multi hash decoding and add saner options#11396
Open
riknoll wants to merge 3 commits into
Open
Conversation
jwunderl
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-microbit#5397
as noted in that issue, the way to use the --multi page was to include a hash like this:
where
lefthashwill end up being applied to the left iframe andrighthashto the right iframe. however, because the delimeter includes the character|, it was often getting encoded automatically as%7cwhich breaks the parsing. this fixes that bug by callingdecodeURIComponenton the hash to make sure all the percent encoded characters are parsed.still, this is imo a silly way to structure that URL, so i've also added a new format that is easier to use. you can now add arguments using query string syntax like so:
or, if you're just referencing two scripts, you can do this:
which will automatically add the
pub:prefix to the hash for the iframes