Skip to content

fix --multi hash decoding and add saner options #11396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riknoll wants to merge 3 commits into
base: master
Choose a base branch
from
+60 −8
Open

fix --multi hash decoding and add saner options #11396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08ee91c
fix --multi hash decoding and add saner options
riknoll Jun 10, 2026
0c6dfce
sync docs
riknoll Jun 10, 2026
91c342d
Merge branch 'master' into dev/riknoll/microbit-multi-hash
riknoll Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions docs/multi.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,36 @@
ifrm.src = select.value + flags + h;
}
function handleHash() {
var route = (window.location.hash || "#");
var parts = route.replace(/^#/, '').split(':|:', 2);
updateSrc(left, selectLeft, parts[0]);
updateSrc(right, selectRight, parts[1]);
var route = decodeURIComponent(window.location.hash || "#");

if (route.indexOf(":|:") !== -1) {
var parts = route.replace(/^#/, '').split(':|:', 2);
updateSrc(left, selectLeft, parts[0]);
updateSrc(right, selectRight, parts[1]);
}
else {
route = route.replace(/^#/, '');
var params = new URLSearchParams(route);
if (params.has("left")) {
updateSrc(left, selectLeft, params.get("left"));
}
else if (params.has("leftscript")) {
updateSrc(left, selectLeft, "pub:" + params.get("leftscript"));
}
else {
updateSrc(left, selectLeft);
}
if (params.has("right")) {
updateSrc(right, selectRight, params.get("right"));
}
else if (params.has("rightscript")) {
updateSrc(right, selectRight, "pub:" + params.get("rightscript"));
}
else {
updateSrc(right, selectRight);
}
}

window.history.replaceState('', '', '#')
}

Expand Down
34 changes: 30 additions & 4 deletions webapp/public/multi.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,36 @@
function handleHash() {
var hashLeft = ""
var hashRight = ""
var route = (window.location.hash || "#");
var parts = route.replace(/^#/, '').split(':|:', 2);
updateSrc(left, parts[0]);
updateSrc(right, parts[1]);
var route = decodeURIComponent(window.location.hash || "#");

if (route.indexOf(":|:") !== -1) {
var parts = route.replace(/^#/, '').split(':|:', 2);
updateSrc(left, parts[0]);
updateSrc(right, parts[1]);
}
else {
route = route.replace(/^#/, '');
var params = new URLSearchParams(route);
if (params.has("left")) {
updateSrc(left, params.get("left"));
}
else if (params.has("leftscript")) {
updateSrc(left, "pub:" + params.get("leftscript"));
}
else {
updateSrc(left);
}
if (params.has("right")) {
updateSrc(right, params.get("right"));
}
else if (params.has("rightscript")) {
updateSrc(right, "pub:" + params.get("rightscript"));
}
else {
updateSrc(right);
}
}

window.history.replaceState('', '', '#')
}
function handleMessage(msg) {
Expand Down
Loading