Repository navigation
tools: fix netlaunch iDRAC10 media, boot and ISO listener lifetime - #909
Draft
Paco Huelsz (frhuelsz) wants to merge 5 commits into
Draft
Paco Huelsz (frhuelsz) wants to merge 5 commits into
Paco Huelsz (frhuelsz) wants to merge 5 commits into
Conversation
Use upstream bmclib discovery fallback for BMCs exposing VirtualMedia under ComputerSystem. Keep manager-scoped discovery and cover both paths with mock Redfish insertion tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Advance bmclib for the gofish schemas API and select the upstream SetBoot fallback to the advertised settings resource. Update netlaunch to use the renamed virtual-media constant. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Paco Huelsz (frhuelsz)
changed the title
Honor netlaunch listener mode instead of canceling on the first ISO fetch. This preserves virtual-media HTTP requests and serial capture after deployment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Paco Huelsz (frhuelsz)
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the native BMC dependencies for two newer Redfish layouts:
The newer gofish API moves redfish types to schemas; netlaunch needs its CD media import/constant updated.
Also honor explicit --port listener mode for plain ISOs: do not cancel the HTTP/serial session after the first ISO fetch. Default one-shot behavior without an explicit port is unchanged. No custom BMC requests or runtime wrappers.
Upstream fixes:
bmc-toolbox/bmclib@105a462
stmcginnis/gofish@41fc97f
Validation: native packages and netlaunch build passed. Temporary mock Redfish checks covered both media locations and both boot-setting endpoints. The actual netlaunch executable completed a fake-BMC deployment and kept serving after HEAD and repeated range requests. The previous binary reproduced first-fetch context cancellation. Tests are not included in this PR. No live boot-setting changes or power-on were performed.