Skip to content

tools: fix netlaunch iDRAC10 media, boot and ISO listener lifetime #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Paco Huelsz (frhuelsz) wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

tools: fix netlaunch iDRAC10 media, boot and ISO listener lifetime #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8413703
Update BMC library for system-scoped virtual media
frhuelsz Oct 28, 2026
d2e5811
Complete mocked Redfish session setup for media tests
frhuelsz Oct 28, 2026
32992ba
Drop virtual-media regression test from dependency update
frhuelsz Oct 28, 2026
fd0082a
Use upstream Redfish settings fallback for boot overrides
frhuelsz Oct 28, 2026
e630bc3
Keep plain ISO serving alive when a listener port is specified
frhuelsz Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module tridenttools
go 1.25.0

require (
github.com/bmc-toolbox/bmclib/v2 v2.0.1-0.20230530141715-da28e42c453f
github.com/bmc-toolbox/bmclib/v2 v2.3.6-0.20260328073115-d46d3bdb603a
github.com/digitalocean/go-libvirt v0.0.0-20250512231903-57024326652b
github.com/dustin/go-humanize v1.0.1
github.com/fatih/color v1.19.0
Expand All @@ -28,10 +28,13 @@ require (
)

require (
dario.cat/mergo v1.0.1 // indirect
github.com/blang/semver/v4 v4.0.0 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/doug-martin/goqu/v9 v9.19.0 // indirect
github.com/flatcar/go-omaha v0.0.2-0.20251014063321-4998849bd39c // indirect
github.com/fxamacker/cbor/v2 v2.9.0 // indirect
github.com/ghodss/yaml v1.0.0 // indirect
github.com/go-gorp/gorp/v3 v3.1.0 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/jackc/pgpassfile v1.0.0 // indirect
Expand All @@ -51,6 +54,8 @@ require (
github.com/rs/zerolog v1.35.1 // indirect
github.com/rubenv/sql-migrate v1.8.1 // indirect
github.com/x448/float16 v0.8.4 // indirect
go.opentelemetry.io/otel v1.44.0 // indirect
go.opentelemetry.io/otel/trace v1.44.0 // indirect
go.yaml.in/yaml/v2 v2.4.2 // indirect
golang.org/x/mod v0.38.0 // indirect
golang.org/x/sync v0.22.0 // indirect
Expand Down Expand Up @@ -80,7 +85,7 @@ require (
github.com/VictorLowther/simplexml v0.0.0-20180716164440-0bff93621230 // indirect
github.com/VictorLowther/soap v0.0.0-20150314151524-8e36fca84b22 // indirect
github.com/alecthomas/kong v1.12.1
github.com/bmc-toolbox/common v0.0.0-20240806132831-ba8adc6a35e3 // indirect
github.com/bmc-toolbox/common v0.0.0-20250112191656-b6de52e8303d // indirect
github.com/fsnotify/fsnotify v1.7.0 // indirect
github.com/go-logr/logr v1.4.3 // indirect
github.com/hashicorp/errwrap v1.1.0 // indirect
Expand All @@ -105,7 +110,7 @@ require (
github.com/spf13/afero v1.15.0 // indirect
github.com/spf13/cast v1.7.0 // indirect
github.com/spf13/pflag v1.0.10 // indirect
github.com/stmcginnis/gofish v0.19.0
github.com/stmcginnis/gofish v0.21.5-0.20260403084051-41fc97fb5a95
github.com/subosito/gotenv v1.6.0 // indirect
github.com/vishvananda/netlink v1.3.0
github.com/vishvananda/netns v0.0.4 // indirect
Expand Down
15 changes: 15 additions & 0 deletions tools/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
dario.cat/mergo v1.0.1 h1:Ra4+bf83h2ztPIQYNP99R6m+Y7KfnARDfID+a+vLl4s=
dario.cat/mergo v1.0.1/go.mod h1:uNxQE+84aUszobStD9th8a29P2fMDhsBdgRYvZOxGmk=
filippo.io/edwards25519 v1.1.0 h1:FNf4tywRC1HmFuKW5xopWpigGjJKiJSV0Cqo0cJWDaA=
filippo.io/edwards25519 v1.1.0/go.mod h1:BxyFTGdWcka3PhytdK4V28tE5sGfRvvvRV7EaN4VDT4=
github.com/DATA-DOG/go-sqlmock v1.5.0 h1:Shsta01QNfFxHCfpW6YH2STWB0MudeXXEWMr20OEh60=
Expand All @@ -18,8 +20,14 @@ github.com/blang/semver/v4 v4.0.0 h1:1PFHFE6yCCTv8C1TeyNNarDzntLi7wMI5i/pzqYIsAM
github.com/blang/semver/v4 v4.0.0/go.mod h1:IbckMUScFkM3pff0VJDNKRiT6TG/YpiHIM2yvyW5YoQ=
github.com/bmc-toolbox/bmclib/v2 v2.0.1-0.20230530141715-da28e42c453f h1:5xXPluhAvpNCmrgVhQesx+GcpPX1pXRyDFtj3JmxT+g=
github.com/bmc-toolbox/bmclib/v2 v2.0.1-0.20230530141715-da28e42c453f/go.mod h1:a3Ra0ce/LV3wAj7AHuphlHNTx5Sg67iQqtLGr1zoqio=
github.com/bmc-toolbox/bmclib/v2 v2.3.5-0.20260220043303-105a46210c27 h1:y8iXElxcTfjMcLhsnSi/6B6ucDb8yAqO7YMrtxs+LVI=
github.com/bmc-toolbox/bmclib/v2 v2.3.5-0.20260220043303-105a46210c27/go.mod h1:2tYJD9JtY1tJxLHhslICrFOZhxE9O4gYMb1nJ5BKI5w=
github.com/bmc-toolbox/bmclib/v2 v2.3.6-0.20260328073115-d46d3bdb603a h1:FDrV9/Nyjhje5ROK5ZhFnMRw2Opnfjmx+n3kdNGBBK0=
github.com/bmc-toolbox/bmclib/v2 v2.3.6-0.20260328073115-d46d3bdb603a/go.mod h1:5ZsFJw5aKs3VMd3N764LSW9wXc/WpUFaXV38ebLPvrA=
github.com/bmc-toolbox/common v0.0.0-20240806132831-ba8adc6a35e3 h1:/BjZSX/sphptIdxpYo4wxAQkgMLyMMgfdl48J9DKNeE=
github.com/bmc-toolbox/common v0.0.0-20240806132831-ba8adc6a35e3/go.mod h1:Cdnkm+edb6C0pVkyCrwh3JTXAe0iUF9diDG/DztPI9I=
github.com/bmc-toolbox/common v0.0.0-20250112191656-b6de52e8303d h1:5c0jhS9jNLm1t3GVEESsWv+p6recFRLGW90zp8HDIDs=
github.com/bmc-toolbox/common v0.0.0-20250112191656-b6de52e8303d/go.mod h1:Cdnkm+edb6C0pVkyCrwh3JTXAe0iUF9diDG/DztPI9I=
github.com/bombsimon/logrusr/v2 v2.0.1 h1:1VgxVNQMCvjirZIYaT9JYn6sAVGVEcNtRE0y4mvaOAM=
github.com/bombsimon/logrusr/v2 v2.0.1/go.mod h1:ByVAX+vHdLGAfdroiMg6q0zgq2FODY2lc5YJvzmOJio=
github.com/cespare/xxhash/v2 v2.3.0 h1:UL815xU9SqsFlibzuggzjXhog7bL6oX9BbNZnL2UFvs=
Expand Down Expand Up @@ -48,6 +56,8 @@ github.com/fsnotify/fsnotify v1.7.0 h1:8JEhPFa5W2WU7YfeZzPNqzMP6Lwt7L2715Ggo0nos
github.com/fsnotify/fsnotify v1.7.0/go.mod h1:40Bi/Hjc2AVfZrqy+aj+yEI+/bRxZnMJyTJwOpGvigM=
github.com/fxamacker/cbor/v2 v2.9.0 h1:NpKPmjDBgUfBms6tr6JZkTHtfFGcMKsw3eGcmD/sapM=
github.com/fxamacker/cbor/v2 v2.9.0/go.mod h1:vM4b+DJCtHn+zz7h3FFp/hDAI9WNWCsZj23V5ytsSxQ=
github.com/ghodss/yaml v1.0.0 h1:wQHKEahhL6wmXdzwWG11gIVCkOv05bNOh+Rxn0yngAk=
github.com/ghodss/yaml v1.0.0/go.mod h1:4dBDuWmgqj2HViK6kFavaiC9ZROes6MMH2rRYeMEF04=
github.com/glebarez/go-sqlite v1.20.3 h1:89BkqGOXR9oRmG58ZrzgoY/Fhy5x0M+/WV48U5zVrZ4=
github.com/glebarez/go-sqlite v1.20.3/go.mod h1:u3N6D/wftiAzIOJtZl6BmedqxmmkDfH3q+ihjqxC9u0=
github.com/go-gorp/gorp/v3 v3.1.0 h1:ItKF/Vbuj31dmV4jxA1qblpSwkl9g1typ24xoe70IGs=
Expand Down Expand Up @@ -193,6 +203,10 @@ github.com/spf13/viper v1.19.0 h1:RWq5SEjt8o25SROyN3z2OrDB9l7RPd3lwTWU8EcEdcI=
github.com/spf13/viper v1.19.0/go.mod h1:GQUN9bilAbhU/jgc1bKs99f/suXKeUMct8Adx5+Ntkg=
github.com/stmcginnis/gofish v0.19.0 h1:fmxdRZ5WHfs+4ExArMYoeRfoh+SAxLELKtmoVplBkU4=
github.com/stmcginnis/gofish v0.19.0/go.mod h1:lq2jHj2t8Krg0Gx02ABk8MbK7Dz9jvWpO/TGnVksn00=
github.com/stmcginnis/gofish v0.20.0 h1:hH2V2Qe898F2wWT1loApnkDUrXXiLKqbSlMaH3Y1n08=
github.com/stmcginnis/gofish v0.20.0/go.mod h1:PzF5i8ecRG9A2ol8XT64npKUunyraJ+7t0kYMpQAtqU=
github.com/stmcginnis/gofish v0.21.5-0.20260403084051-41fc97fb5a95 h1:Du1PYgdLyb6B6KuTib/USTlqBLdGoEpwyerGlz9G2CA=
github.com/stmcginnis/gofish v0.21.5-0.20260403084051-41fc97fb5a95/go.mod h1:PzF5i8ecRG9A2ol8XT64npKUunyraJ+7t0kYMpQAtqU=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw=
github.com/stretchr/objx v0.5.2 h1:xuMeJ0Sdp5ZMRXx/aWO6RZxdr3beISkG5/G/aIRr3pY=
Expand Down Expand Up @@ -228,6 +242,7 @@ go.opentelemetry.io/otel/trace v1.44.0 h1:jxF5CsGYCe74MCRx2X4g7WsY/VBKRqqpNvXlX/
go.opentelemetry.io/otel/trace v1.44.0/go.mod h1:oLl1jrMQAVo6v3GAggN+1VH9VIz9iUSvW53sW1Q8PIE=
go.uber.org/goleak v1.2.1 h1:NBol2c7O1ZokfZ0LEU9K6Whx/KnwvepVetCUhtKja4A=
go.uber.org/goleak v1.2.1/go.mod h1:qlT2yGI9QafXHhZZLxlSuNsMw3FFLxBr+tBRlmO1xH4=
go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto=
go.uber.org/multierr v1.11.0 h1:blXXJkSxSSfBVBlC76pxqeO+LN3aDfLQo+309xJstO0=
go.uber.org/multierr v1.11.0/go.mod h1:20+QtiLqy0Nd6FdQB9TLXag12DsQkrbs3htMFfDN80Y=
go.yaml.in/yaml/v2 v2.4.2 h1:DzmwEr2rDGHl7lsFgAHxmNz/1NlQ7xLIrlN2h5d1eGI=
Expand Down
8 changes: 5 additions & 3 deletions tools/pkg/netlaunch/netlaunch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"github.com/bmc-toolbox/bmclib/v2"
"github.com/google/uuid"
log "github.com/sirupsen/logrus"
"github.com/stmcginnis/gofish/redfish"
"github.com/stmcginnis/gofish/schemas"
"gopkg.in/yaml.v2"

"tridenttools/pkg/isopatcher"
Expand Down Expand Up @@ -217,7 +217,9 @@ func RunNetlaunch(ctx context.Context, config *NetLaunchConfig) error {
mux.HandleFunc("/provision.iso", func(w http.ResponseWriter, r *http.Request) {
isoLogFunc(r.RemoteAddr)
http.ServeContent(w, r, "provision.iso", time.Now(), bytes.NewReader(iso))
terminateFunc()
if !enable_phonehome_listening {
terminateFunc()
}
})
}

Expand Down Expand Up @@ -303,7 +305,7 @@ func RunNetlaunch(ctx context.Context, config *NetLaunchConfig) error {
}

log.WithField("url", iso_location).Info("Setting virtual media to ISO")
if _, err = client.SetVirtualMedia(bmcCtx, string(redfish.CDMediaType), iso_location); err != nil {
if _, err = client.SetVirtualMedia(bmcCtx, string(schemas.CDVirtualMediaType), iso_location); err != nil {
return fmt.Errorf("failed to set virtual media: %w", err)
}

Expand Down
Loading