Skip to content

chore(settings): remove redundant React imports#20612

Open
vbudhram wants to merge 1 commit into
mainfrom
fxa-13744
Open

chore(settings): remove redundant React imports#20612
vbudhram wants to merge 1 commit into
mainfrom
fxa-13744

Conversation

@vbudhram
Copy link
Copy Markdown
Contributor

Because

  • The jsx: react-jsx transform means import React from 'react' is no longer needed for JSX
  • The recent Storybook upgrade dropped the last build constraint that still required it

This pull request

  • Drops the default import React from 'react'; line from files in packages/fxa-settings where the React namespace wasn't used
  • Rewrites React.* references as named imports in six stories that still relied on the namespace: BoxButton, ButtonPasskeySignin, CardHeader, Settings/Modal, Settings/ModalVerifySession, and .storybook/preview.tsx
  • Some unrelated files got minor Prettier reformatting from the repo's lint-staged hook on commit

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-13744

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

Copilot AI review requested due to automatic review settings May 15, 2026 17:47
@vbudhram vbudhram requested a review from a team as a code owner May 15, 2026 17:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@vbudhram vbudhram requested a review from LZoog May 15, 2026 18:49
@vbudhram vbudhram self-assigned this May 15, 2026
@vbudhram
Copy link
Copy Markdown
Contributor Author

@LZoog tests pass and storybook work 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants