Skip to content

chore(settings): remove redundant React imports #20612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbudhram merged 1 commit into from
May 18, 2026
Merged

chore(settings): remove redundant React imports #20612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion packages/fxa-settings/.storybook/design-guide/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import LinkExternal from 'fxa-react/components/LinkExternal';

const Header = () => {
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/.storybook/design-guide/Page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import Header from './Header';
import AppLocalizationProvider from 'fxa-react/lib/AppLocalizationProvider';

Expand Down
2 changes: 0 additions & 2 deletions packages/fxa-settings/.storybook/design-guide/Snippet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';

const Snippet = ({ moarClasses = '', children }) => (
<code className={`bg-grey-100 text-sm px-1 rounded-sm ${moarClasses}`}>
{children}
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/.storybook/design-guide/main.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import type { Meta, StoryObj } from '@storybook/react';
import tailwindConfig from '../../../fxa-react/configs/tailwind';
import resolveConfig from 'tailwindcss/resolveConfig';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/.storybook/design-guide/pages/Breakpoints.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import Page from '../Page';
import Copiable from '../Copiable';
import LinkExternal from 'fxa-react/components/LinkExternal';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/.storybook/design-guide/pages/Colors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import Page from '../Page';
import Copiable from '../Copiable';
import Snippet from '../Snippet';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/.storybook/design-guide/pages/Introduction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import Page from '../Page';
import LinkExternal from 'fxa-react/components/LinkExternal';
import Copiable from '../Copiable';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/.storybook/design-guide/pages/Spacing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import Page from '../Page';
import Copiable from '../Copiable';
import Snippet from '../Snippet';
Expand Down
4 changes: 2 additions & 2 deletions packages/fxa-settings/.storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import '../src/styles/tailwind.out.css';
import './design-guide/design-guide.css';
import React, { useEffect } from 'react';
import { ReactNode, useEffect } from 'react';
import type { Decorator } from '@storybook/react';
import { ThemeProvider, useTheme } from '../src/models/contexts/ThemeContext';

Expand All @@ -13,7 +13,7 @@ const ThemeSync = ({
children,
}: {
theme: string;
children: React.ReactNode;
children: ReactNode;
}) => {
const { setThemePreference } = useTheme();
useEffect(() => {
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/AlternativeAuthOptions/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { Meta } from '@storybook/react';
import { action } from '@storybook/addon-actions';
import { withLocalization } from 'fxa-react/lib/storybooks';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/AlternativeAuthOptions/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { renderWithLocalizationProvider } from 'fxa-react/lib/test-utils/localizationProvider';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/AlternativeAuthOptions/mocks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { LocationProvider } from '@reach/router';
import AlternativeAuthOptions, { AlternativeAuthOptionsProps } from '.';
import Banner from '../Banner';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/AppLayout/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import AppLayout from './index';
import { Meta } from '@storybook/react';
import { withLocalization } from 'fxa-react/lib/storybooks';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/AppLayout/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { screen } from '@testing-library/react';
import { renderWithLocalizationProvider } from 'fxa-react/lib/test-utils/localizationProvider';
import AppLayout from '.';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/Banner/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { Meta } from '@storybook/react';
import AppLayout from '../AppLayout';
import { withLocalization } from 'fxa-react/lib/storybooks';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/Banner/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { render, screen, fireEvent, waitFor } from '@testing-library/react';
import Banner from './index';
import { BannerProps } from './interfaces';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/Banner/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { BannerProps } from './interfaces';
import {
CheckmarkCircleOutlineCurrentIcon,
Expand Down
4 changes: 2 additions & 2 deletions packages/fxa-settings/src/components/BoxButton/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { ReactNode } from 'react';
import { Meta } from '@storybook/react';
import { action } from '@storybook/addon-actions';
import { withLocalization } from 'fxa-react/lib/storybooks';
Expand All @@ -23,7 +23,7 @@ export default {
},
} as Meta;

const Container = ({ children }: { children: React.ReactNode }) => (
const Container = ({ children }: { children: ReactNode }) => (
<div className="card mx-auto max-w-md">{children}</div>
);

Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/BoxButton/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { renderWithLocalizationProvider } from 'fxa-react/lib/test-utils/localizationProvider';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/BrandMessaging/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { Meta } from '@storybook/react';
import { withLocalization } from 'fxa-react/lib/storybooks';
import { BrandMessaging } from '.';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/BrandMessaging/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { act, screen } from '@testing-library/react';
import { renderWithLocalizationProvider } from 'fxa-react/lib/test-utils/localizationProvider';
import { BrandMessaging, bannerClosedLocalStorageKey } from '.';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/ButtonBack/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { Meta } from '@storybook/react';
import { withLocalization } from 'fxa-react/lib/storybooks';
import AppLayout from '../AppLayout';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/ButtonDownloadRecoveryKeyPDF/RecoveryKeyPDF.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import {
Document,
Font,
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/ButtonDownloadRecoveryKeyPDF/VectorImagesForPdf.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { Svg, Path, Rect, Circle } from '@react-pdf/renderer';

/*
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/ButtonDownloadRecoveryKeyPDF/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { Meta } from '@storybook/react';
import AppLayout from '../AppLayout';
import ButtonDownloadRecoveryKeyPDF from '.';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/ButtonDownloadRecoveryKeyPDF/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { fireEvent, screen } from '@testing-library/react';
import { renderWithLocalizationProvider } from 'fxa-react/lib/test-utils/localizationProvider';
import { ButtonDownloadRecoveryKeyPDF, getFilename } from '.';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/ButtonDownloadRecoveryKeyPDF/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { RelierCmsInfo, useAlertBar, useFtlMsgResolver } from '../../models';
import { pdf } from '@react-pdf/renderer';
import { saveAs } from 'file-saver';
Expand Down
4 changes: 2 additions & 2 deletions packages/fxa-settings/src/components/ButtonPasskeySignin/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { useState } from 'react';
import ButtonPasskeySignin from '.';
import { withLocalization } from 'fxa-react/lib/storybooks';
import { Meta } from '@storybook/react';
Expand All @@ -15,7 +15,7 @@ export default {
} as Meta;

export const Default = () => {
const [isLoading, setIsLoading] = React.useState(false);
const [isLoading, setIsLoading] = useState(false);

const handleClick = () => {
action('clicked')();
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/ButtonPasskeySignin/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { renderWithLocalizationProvider } from 'fxa-react/lib/test-utils/localizationProvider';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/ButtonPasskeySignin/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { PasskeyIcon } from '../Icons';
import { FtlMsg } from 'fxa-react/lib/utils';
import BoxButton from '../BoxButton';
Expand Down
4 changes: 2 additions & 2 deletions packages/fxa-settings/src/components/CardHeader/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { ComponentProps } from 'react';
import CardHeader from '.';
import AppLayout from '../AppLayout';
import { Meta } from '@storybook/react';
Expand All @@ -23,7 +23,7 @@ export default {
} as Meta;

const storyWithProps = (
props: React.ComponentProps<typeof CardHeader>,
props: ComponentProps<typeof CardHeader>,
storyName?: string
) => {
const story = () => (
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/CardHeader/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { screen } from '@testing-library/react';
import { renderWithLocalizationProvider } from 'fxa-react/lib/test-utils/localizationProvider';
import CardHeader from '.';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/CardLoadingSpinner/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import type { Meta, StoryObj } from '@storybook/react';
import { CardLoadingSpinner } from './';
import { SpinnerType } from 'fxa-react/components/LoadingSpinner';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/CardLoadingSpinner/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { screen } from '@testing-library/react';
import { SpinnerType } from 'fxa-react/components/LoadingSpinner';
import { CardLoadingSpinner } from './';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/CardLoadingSpinner/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import LoadingSpinner, {
SpinnerType,
} from 'fxa-react/components/LoadingSpinner';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/ChooseNewsletters/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import ChooseNewsletters from '.';
import AppLayout from '../AppLayout';
import { Meta } from '@storybook/react';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/ChooseNewsletters/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { screen } from '@testing-library/react';
import { renderWithLocalizationProvider } from 'fxa-react/lib/test-utils/localizationProvider';
import { getFtlBundle, testAllL10n } from 'fxa-react/lib/test-utils';
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/CmsButtonWithFallback/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { Meta } from '@storybook/react';
import CmsButtonWithFallback from '.';

Expand Down
1 change: 0 additions & 1 deletion packages/fxa-settings/src/components/CmsButtonWithFallback/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import React from 'react';
import { render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import CmsButtonWithFallback from '.';
Expand Down
Loading
Loading