fix(NcAppNavigation): also emit navigation-toggled on mobile change#8353
Open
fix(NcAppNavigation): also emit navigation-toggled on mobile change#8353
navigation-toggled on mobile change#8353Conversation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
3 tasks
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8353 +/- ##
==========================================
+ Coverage 52.37% 52.38% +0.01%
==========================================
Files 104 104
Lines 3393 3394 +1
Branches 989 989
==========================================
+ Hits 1777 1778 +1
Misses 1360 1360
Partials 256 256 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
Contributor
Author
|
Ping π |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we keep and adjust the internal state and react to
isMobile, we should advertise that state as we do for the normal open/close methods.π Checklist
stable8for maintained Vue 2 version or not applicable