Skip to content

fix(NcAppNavigation): also emit navigation-toggled on mobile change#8353

Open
skjnldsv wants to merge 1 commit intomainfrom
fix/ncappnav-emit-mobile
Open

fix(NcAppNavigation): also emit navigation-toggled on mobile change#8353
skjnldsv wants to merge 1 commit intomainfrom
fix/ncappnav-emit-mobile

Conversation

@skjnldsv
Copy link
Copy Markdown
Contributor

@skjnldsv skjnldsv commented Mar 25, 2026

Since we keep and adjust the internal state and react to isMobile, we should advertise that state as we do for the normal open/close methods.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • πŸ“˜ Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the 9.6.0 milestone Mar 25, 2026
@skjnldsv skjnldsv requested review from ShGKme and susnux March 25, 2026 08:51
@skjnldsv skjnldsv self-assigned this Mar 25, 2026
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component labels Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 52.38%. Comparing base (6eec54e) to head (eb2be2c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8353      +/-   ##
==========================================
+ Coverage   52.37%   52.38%   +0.01%     
==========================================
  Files         104      104              
  Lines        3393     3394       +1     
  Branches      989      989              
==========================================
+ Hits         1777     1778       +1     
  Misses       1360     1360              
  Partials      256      256              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skjnldsv
Copy link
Copy Markdown
Contributor Author

skjnldsv commented Apr 1, 2026

Ping πŸ†™

@Antreesy Antreesy modified the milestones: 9.6.0, 9.7.0 Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants