Skip to content

fix(docs): fix sidebar scrollIntoView selecting last item erroneously #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 2 commits into from
Apr 4, 2026
+5 −4
Merged

fix(docs): fix sidebar scrollIntoView selecting last item erroneously #728

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6a947c
fix(docs): avoid scrolling to bottom when active sidebar link is not …
Botato300 Mar 30, 2026
19d7cda
Merge branch 'nodejs:main' into main
Botato300 Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/generators/legacy-html/assets/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,18 +203,19 @@ const setupCopyButton = () => {
function setupSidebarScroll() {
const sidebarLinks = document.querySelectorAll('#column2 a');

let link;
for (link of sidebarLinks) {
let activeLink = null;
for (const link of sidebarLinks) {
if (link.pathname === window.location.pathname) {
activeLink = link;
break;
}
}

if (!link) {
if (!activeLink) {
return;
Comment thread
avivkeller marked this conversation as resolved.
}

link.scrollIntoView({ behavior: 'smooth', block: 'center' });
activeLink.scrollIntoView({ behavior: 'smooth', block: 'center' });
}

// Initialize either on DOMContentLoaded or immediately if already loaded
Expand Down
Loading