Skip to content

test: wait for prompt before initial break in debugger tests#62489

Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-initial-break-flaky
Open

test: wait for prompt before initial break in debugger tests#62489
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-initial-break-flaky

Conversation

@inoway46
Copy link
Copy Markdown
Contributor

@inoway46 inoway46 commented Mar 29, 2026

This fixes flakiness around waitForInitialBreak() in debugger tests.

waitForInitialBreak() can be flaky during startup because the CLI may already attach and print debug> before the initial break ... in output arrives.

Example CI log: https://github.com/nodejs/node/actions/runs/23657399006

    '< For help, see: https://nodejs.org/en/docs/inspector\n' +
    '< \n' +
    'connecting to 127.0.0.1:54872 ...\n' +
    ' ok\n' +
    '\n' +
    '\n' +
    '< Debugger attached.\n' +
    '< \n' +
    '\n' +
    'debug> '

In some CI runs, tests end up waiting on that break message while startup output is still racing.
There are similar flakes in other tests, but this PR focuses on the failures seen in the past week.

Recent CI failures:

Refs: #61762

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 29, 2026
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inoway46 inoway46 marked this pull request as ready for review March 29, 2026 06:15
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (cc96741) to head (9f7ff44).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62489      +/-   ##
==========================================
- Coverage   91.55%   89.70%   -1.85%     
==========================================
  Files         351      692     +341     
  Lines      147653   213986   +66333     
  Branches    23224    41050   +17826     
==========================================
+ Hits       135179   191963   +56784     
- Misses      12217    14088    +1871     
- Partials      257     7935    +7678     

see 462 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants