test: wait for prompt before initial break in debugger tests#62489
Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
Open
test: wait for prompt before initial break in debugger tests#62489inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46 wants to merge 1 commit intonodejs:mainfrom
Conversation
inoway46
commented
Mar 29, 2026
Contributor
Author
There was a problem hiding this comment.
This test seems the most frequently failed in the past week.
https://github.com/nodejs/node/actions/runs/23689423627
https://github.com/nodejs/node/actions/runs/23524571217
https://github.com/nodejs/node/actions/runs/23362176847
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62489 +/- ##
==========================================
- Coverage 91.55% 89.70% -1.85%
==========================================
Files 351 692 +341
Lines 147653 213986 +66333
Branches 23224 41050 +17826
==========================================
+ Hits 135179 191963 +56784
- Misses 12217 14088 +1871
- Partials 257 7935 +7678 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes flakiness around
waitForInitialBreak()in debugger tests.waitForInitialBreak()can be flaky during startup because the CLI may already attach and printdebug>before the initialbreak ... inoutput arrives.Example CI log: https://github.com/nodejs/node/actions/runs/23657399006
In some CI runs, tests end up waiting on that break message while startup output is still racing.
There are similar flakes in other tests, but this PR focuses on the failures seen in the past week.
Recent CI failures:
Refs: #61762