Skip to content

test: wait for prompt before initial break in debugger tests #62489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inoway46 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

test: wait for prompt before initial break in debugger tests #62489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/parallel/test-debugger-backtrace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const path = require('path');

async function runTest() {
try {
await cli.waitForPrompt();
await cli.waitForInitialBreak();
await cli.waitForPrompt();
await cli.stepCommand('c');
Expand Down
1 change: 1 addition & 0 deletions test/parallel/test-debugger-break.js
View file
Open in desktop
Copy link
Copy Markdown
Contributor Author

@inoway46 inoway46 Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test seems the most frequently failed in the past week.
https://github.com/nodejs/node/actions/runs/23689423627
https://github.com/nodejs/node/actions/runs/23524571217
https://github.com/nodejs/node/actions/runs/23362176847

Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const script = path.relative(process.cwd(), scriptFullPath);
const cli = startCLI([script]);

(async () => {
await cli.waitForPrompt();
await cli.waitForInitialBreak();
await cli.waitForPrompt();
assert.deepStrictEqual(
Expand Down
3 changes: 2 additions & 1 deletion test/parallel/test-debugger-clear-breakpoints.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ const path = require('path');
throw error;
}

return cli.waitForInitialBreak()
return cli.waitForPrompt()
.then(() => cli.waitForInitialBreak())
.then(() => cli.waitForPrompt())
.then(() => cli.command('sb("break.js", 3)'))
.then(() => cli.command('sb("break.js", 9)'))
Expand Down
1 change: 1 addition & 0 deletions test/parallel/test-debugger-sb-before-load.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const otherScript = path.relative(process.cwd(), otherScriptFullPath);
const cli = startCLI([script]);

(async () => {
await cli.waitForPrompt();
await cli.waitForInitialBreak();
await cli.waitForPrompt();
await cli.command('sb("other.js", 2)');
Expand Down
Loading