Skip to content

fix: update specs to use github root as the source of plugins for the install#45

Merged
Cesar-M-Diaz merged 2 commits into
mainfrom
cesar/spec-update
Jun 29, 2026
Merged

fix: update specs to use github root as the source of plugins for the install#45
Cesar-M-Diaz merged 2 commits into
mainfrom
cesar/spec-update

Conversation

@Cesar-M-Diaz

@Cesar-M-Diaz Cesar-M-Diaz commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Updated cross-harness installation to use GitHub-root plugin manifests for Claude, Codex, and Antigravity.
    • Pi skill materialization is now sourced from the repository root skills/ during packaging.
  • Bug Fixes
    • Clarified that authentication only occurs via explicit setup/login, not from installation or activation steps.
    • Updated uninstall/health-check behavior and remediation to match the new root-staged install flow.
  • Documentation
    • Reworked design, proposal, specs, and task checklists to reflect the new GitHub-root distribution model and validation steps.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0a0f4875-98fc-42f3-9a59-ddc12e7e804a

📥 Commits

Reviewing files that changed from the base of the PR and between 8518824 and d96f0bf.

📒 Files selected for processing (1)
  • openspec/changes/cross-harness-plugin-installer/design.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • openspec/changes/cross-harness-plugin-installer/design.md

Walkthrough

All four cross-harness plugin installer spec documents now describe a GitHub-root plugin model with committed root manifests, root skills/, and root-manifest generation via pnpm plugin:root, replacing the prior generated native artifact flow.

Changes

Cross-harness plugin installer: GitHub-root model

Layer / File(s) Summary
Proposal: architecture, components, and acceptance criteria
openspec/changes/cross-harness-plugin-installer/proposal.md
Replaces the architecture section with the GitHub-root plugin model, revises uninstall/rollback guidance, updates affected scripts inventory, rewrites success criteria to use pnpm plugin:root/plugin:root:check, and rewrites per-harness acceptance test steps.
Design doc: architecture, repo layout, and rationale
openspec/changes/cross-harness-plugin-installer/design.md
Updates the top-level architecture label, repository layout tree, auth and skills rules, Pi package name, data-flow diagrams, uninstall wording, canonical skills location, and migration strategy to match the GitHub-root model.
Installation/auth spec: scenarios, per-harness mappings, and doctor checks
openspec/changes/cross-harness-plugin-installer/specs/installation-and-auth.md
Rewrites installation scenarios for root-manifest materialization and GitHub-root staged installs; updates failure, token-expiry, uninstall, and doctor wording; rewrites Claude, Codex CLI, and Antigravity root-file mappings; changes Pi skill source to root skills/.
Tasks: amendment, updated commands, and E2E scope
openspec/changes/cross-harness-plugin-installer/tasks.md
Adds a 2026-06-24 amendment with the GitHub-root model checklist, marks prior artifact tasks as superseded, updates the pnpm --filter value in Task 22b, updates the npx package name in Task 30, and revises Task 40's E2E description to target GitHub-root installs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

  • nodesource/nsolid-plugin#1: Reworks the same cross-harness installer planning docs, moving from the initial marketplace-wrapper/native-artifacts model to the GitHub-root plugin-manifest model.
  • nodesource/nsolid-plugin#41: Updates the auth/setup messaging around explicit nsolid-plugin setup --harness <harness> flows that this PR’s docs now reference.
  • nodesource/nsolid-plugin#43: Closely related installer-architecture documentation changes covering the same GitHub-root model transition.

Suggested reviewers

  • edsadr
  • dobleuber
  • mafesernaarboleda

Poem

🐇 I hopped through the repo root, bright and keen,
No .tgz trails where the old path had been.
With plugin:root, the manifests bloom,
And skills at the root make the harnesses zoom.
Claude, Codex, Antigravity dance in a row —
A tidy new path for the bunny to know.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: shifting install specs to treat the GitHub root as the plugin source.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@openspec/changes/cross-harness-plugin-installer/design.md`:
- Line 495: Add a language identifier to each fenced diagram block in the design
markdown so the markdown linter stops reporting MD040 warnings. Update the
relevant diagram fences in the sections containing the pnpm plugin and GitHub
install diagrams to use text, and make sure every affected fence in the document
is changed consistently.
- Around line 54-55: The native install definition still uses leftover
“generated harness plugin artifact” wording, which conflicts with the
GitHub-root model used elsewhere in the doc. Update the native install bullet in
the design section referenced by the install flow to describe the harness
loading the plugin from the GitHub-root-based native path, and keep the fallback
install/Pi exception wording unchanged while removing any artifact-centric
phrasing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6535d815-e85a-495c-b5ee-a24e54e184a6

📥 Commits

Reviewing files that changed from the base of the PR and between f8807d7 and 8518824.

📒 Files selected for processing (4)
  • openspec/changes/cross-harness-plugin-installer/design.md
  • openspec/changes/cross-harness-plugin-installer/proposal.md
  • openspec/changes/cross-harness-plugin-installer/specs/installation-and-auth.md
  • openspec/changes/cross-harness-plugin-installer/tasks.md

Comment thread openspec/changes/cross-harness-plugin-installer/design.md Outdated
Comment thread openspec/changes/cross-harness-plugin-installer/design.md Outdated

@edsadr edsadr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cesar-M-Diaz Cesar-M-Diaz merged commit d96f0bf into main Jun 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants