fix: update specs to use github root as the source of plugins for the install#45
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAll four cross-harness plugin installer spec documents now describe a GitHub-root plugin model with committed root manifests, root ChangesCross-harness plugin installer: GitHub-root model
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openspec/changes/cross-harness-plugin-installer/design.md`:
- Line 495: Add a language identifier to each fenced diagram block in the design
markdown so the markdown linter stops reporting MD040 warnings. Update the
relevant diagram fences in the sections containing the pnpm plugin and GitHub
install diagrams to use text, and make sure every affected fence in the document
is changed consistently.
- Around line 54-55: The native install definition still uses leftover
“generated harness plugin artifact” wording, which conflicts with the
GitHub-root model used elsewhere in the doc. Update the native install bullet in
the design section referenced by the install flow to describe the harness
loading the plugin from the GitHub-root-based native path, and keep the fallback
install/Pi exception wording unchanged while removing any artifact-centric
phrasing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6535d815-e85a-495c-b5ee-a24e54e184a6
📒 Files selected for processing (4)
openspec/changes/cross-harness-plugin-installer/design.mdopenspec/changes/cross-harness-plugin-installer/proposal.mdopenspec/changes/cross-harness-plugin-installer/specs/installation-and-auth.mdopenspec/changes/cross-harness-plugin-installer/tasks.md
Summary by CodeRabbit
skills/during packaging.setup/login, not from installation or activation steps.