Repository navigation
fix: refuse sign-script argv paths - #18
Merged
Merged
Conversation
Read the launcher path from the proxy pipe only. Firewall trust module still signs in-process. Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Close the
--sign-scriptVerifyCache stamp so a shell cannot mint trust for an arbitrary launcher.Why
The flag accepted a path on argv with no parent check. That is a silent local trust backdoor.
nvm firewall trust modulestill signs in-process and is unchanged.Testing
Unit tests: proxy parent + matching pipe passes; cmd.exe parent fails; console stdin fails; pipe PID mismatch fails; publisher mismatch fails; argv-style extra args are refused by the CLI (
len(os.Args) != 2). Yarn Classic bin and installs tree remain delegated launcher paths.Risk
Unsigned local debug builds fail closed on the proxy helper (prompt-path re-sign). Users can still trust via
nvm firewall trust module. PPID spoof without the parent's pipe still fails.