Skip to content

fix: refuse sign-script argv paths #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coreybutler merged 1 commit into from
Oct 24, 2026
Merged

fix: refuse sign-script argv paths #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,27 @@ func main() {
}
return
case "--sign-script":
// Force-resign one launcher after trust prompt (bypass TrustedModules gate).
if len(os.Args) < 3 {
fmt.Fprint(os.Stderr, "missing script path for --sign-script\n")
// Proxy-only helper after a trust prompt. Path arrives on stdin (anonymous
// pipe from proxy.exe). argv is ignored so a shell cannot stamp VerifyCache.
if len(os.Args) != 2 {
fmt.Fprint(os.Stderr, "sign-script refused: path must arrive on the proxy pipe\n")
os.Exit(1)
}
settings.Load()
if err := verifycache.SignScript(os.Args[2]); err != nil {
if err := verifycache.AuthorizeSignScriptFromParent(); err != nil {
fmt.Fprintln(os.Stderr, err.Error())
os.Exit(1)
}
scriptPath, err := verifycache.ReadSignScriptPath(os.Stdin)
if err != nil {
fmt.Fprintln(os.Stderr, err.Error())
os.Exit(1)
}
if !verifycache.IsDelegatedLauncherPath(scriptPath) {
fmt.Fprint(os.Stderr, "sign-script refused: path is not a delegated launcher\n")
os.Exit(1)
}
if err := verifycache.SignScript(scriptPath); err != nil {
fmt.Fprintln(os.Stderr, err.Error())
os.Exit(1)
}
Expand Down
Loading